Fix #141 Determine --procsPerNode automatically, reuse shared memory communicator, improve output #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #94 outer_limits crashes if too many processes are used (outer_limits code did not set procsPerNode correctly) TODO: get rid of procsPerNode option
Running with 6 processes caused crash before.
--procsPerNode is marked as obsolete and left for backward compatibility.
… (debug mode) After the refactoring, there are two constructors - Timers() and Timers(env, debug). Old Timers(false) is replaced with Timers(), old Timers(verbosity >= debug) - with Timers(env, verbosity >= debug).
…ree MPI communicator
Print primal dimension, dual dimension and number of SDP blocks at SDP_Solver constructor
Kept it in simple SDPB test to check backward compatibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added
Environmentobject (initialized at SDPB start) which calculates number of nodes and procs per node by creating an MPI shared memory communicator.This allowed to make the following improvements:
--procsPerNodeoption is marked as obsolete and left for backward compatibility (if you set--procsPerNode, SDPB prints warning and ignores it).node=1 start sdpb.solveinstead of (less clear)128 sdpb.solve.Environmentand then reuse it.Other minor changes:
copy_matrix_from_root(), fix MPI communicator leak.