Fix #159 Memory leak in binary SDP deserialization #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
El::Matrix::Control() does not take ownership correctly, which caused theleak https://gitlab.com/bootstrapcollaboration/elemental/-/issues/3
…sed RAM consumption We don't need any tracking, we're just writing arrays.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #159
Memory leak was caused by bug in
El::Matrix::Control(), so we don't use this method now.I also disabled Object tracking in boost serialization for out types.
This mechanism may sometimes cause memory issues (according to some StackOverflow questions), and we don't need it - we are simply reading/writing arrays.