Fix #99 Push/pop Timer name prefixes #146
Merged
+198
−122
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
ScopedTimer
to ensure that nested timers will have correct prefixes, see changes inTimers.hxx
. Also added asserts to ensure that nested timer always stops before parent."sdpb.solve.run.iter_XXX"
for each solver iteration.sdp2input
.Timer::elapsed_milliseconds()
: show correct time even if timer is still running.ScopedTimer
now temporarily adds its name toTimers::prefix
.Example:
The only change to SDPB behaviour is timer names printed to
profiling.*
in debug mode. Beside that, this PR is mainly about improving code quality.