Test and benchmark for block_data SDP serialization (JSON/binary) #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bin and .json You can run benchmark as ./build/unit_tests [!benchmark] --benchmark-samples 10 --benchmark-no-analysis On my laptop, binary format is ~20x-30x faster than JSON for combined write+read to an in-memory stringstream. If disk IO is a bottleneck (which sounds more realistic), one can expect more moderate speedup, ~2.4x because binary format is more compact than JSON. This is a part of davidsd#111 Benchmarks for reading/writing sdp.zip.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
block_dataserialization tounit tests.DIFFfunctions used in both unit and integration tests.block_data_serialization.testwrites block_data (constraint matrixB, constraint vectorcand blilinear bases) to stringstream and then reads them back.On my laptop, the benchmarking results are kind of unstable, but generally show ~20x-30x speedup for binary format compared to JSON (see #79).
Note that in real applications the expected bottlneck is disk IO, so one can expect up to ~2.4x speedup.
I observed such numbers for writing sdp in small end-to-end tests, but they should be taken with a grain of salt. I haven't benchmarked any big problem.
Note that, by default, Catch2 framework does not run test cases marked by
[!benchmark]To run benchmark, run unit_tests as follows:
Catch2 by default uses 100 samples (i.e. runs each benchmark 100 times) and prints detailed statistics.
For a simple and fast output, you can run, e.g.,
More information on Catch2 benchmarks and command-line options:
https://github.com/catchorg/Catch2/blob/devel/docs/benchmarks.md
https://github.com/catchorg/Catch2/blob/devel/docs/command-line.md