Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bigint-syrk-blas: split P window according to --maxSharedMemory limit #204

Closed
Tracked by #207
vasdommes opened this issue Mar 3, 2024 · 0 comments
Closed
Tracked by #207
Milestone

Comments

@vasdommes
Copy link
Collaborator

vasdommes commented Mar 3, 2024

See details in parent issue #207

If total size for P (input) and Q (output) windows exceeds --maxSharedMemory, we should split P window. When calculating Q = P^T P, we should fill the window several times (taking different input block rows) and call BLAS each time to update output window.

@vasdommes vasdommes added this to the 2.8.0 milestone Mar 3, 2024
vasdommes added a commit that referenced this issue Mar 3, 2024
…ory limit

In unit tests, we test two cases:
- no memory limit (no P window splitting)
- memory limit ensuring that only 3 rows fit into P window.
see calculate_matrix_square.test.cxx

In end-to-end.test.cxx, we set --maxSharedMemory=1M for two realistic cases, thus enforcing split factors 4 and 6.
In other cases, limit is not set.

TODO: update Readme.md
TODO: split also Q (output) window, if necessary.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant