Allow fully templated commands #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the 'environments' experiment is over. The inversed command nesting was strange and hard to reason about and brought little advantages (reducing config file duplication) This duplication can be managed by using yaml anchors. Advantages: * the cmd can be completely removed by a template rendering, allowing conditionnal commands * duplication detection is handled at the yaml parsing phase * better semantics for parameter separation
joining in the subprocess erroneously elides the arguments that are passed, making assertions difficult/impossible.
It is up to the user to add additionnal quotes to keep a potential token group together. This change allows for conditional cmd construction
davidovich
force-pushed
the
allow-fully-templated-commands
branch
from
83d1ce7 to
a1fa749
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change.
The config has been simplified to warrant a
cmd:field inhandles:This allows conditional commands to be specified. One use case is that the consuming executables can specify docker environments when called from host, or remove the docker call when called inside the container.