Last minute fixes #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The effect of this is that they do not show up in help, but are shown in completions. Fix bug where summonable commands were added to the wrong sub-command (list command). This was missed because there were no tests with run and without runl subcommands. This is addressed. Ensure that completion still works if summonables are not commands. Hides the help subcommand because we have a --help flag. Fixes root_tests that were written in a way that they were gathering state in the root creation helper (was called at test table creation time).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings final touches after experimenting with a real implementation.
Allows disabling summonables as commands in config
The effect of this is that they do not show up in help, but are shown in
completions.
Fix bug where summonable commands were added to the wrong sub-command
(list command). This was missed because there were no tests with run
and without runl subcommands. This is addressed.
Ensure that completion still works if summonables are not commands.
Hides the help subcommand because we have a --help flag.
Fixes root_tests that were written in a way that they were gathering
state in the root creation helper (was called at test table creation
time).