Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix all test failures except for 8 #126

Merged

Conversation

sadguitarius
Copy link
Contributor

Here's the fix for local_alsa_multi_listener. I just changed the one statement and this should fix most of the errors. I found a couple of other compiler errors when I tried doing a clang build but I don't think they're screwing up the tests. The fixes for those are not included here but I can submit another PR once this is sorted out.

@sadguitarius sadguitarius changed the title fix all test failures except for #8 fix all test failures except for 8 Sep 29, 2024
@davidmoreno davidmoreno merged commit 6e245e3 into davidmoreno:master Sep 29, 2024
1 check failed
@sadguitarius
Copy link
Contributor Author

I'm still getting test 8 failing on void test_client_try_several_connections and a segfault on test 7. The segfault goes away when I build with clang. I'm pretty certain this has nothing to do with the alsa additions, but I do see that test 8 is failing on the master branch now. I'd have to look more closely at what the test is doing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants