Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TorrentListBox: make placeholder internal #190

Merged
merged 1 commit into from
Feb 6, 2023
Merged

Conversation

danirabbit
Copy link
Collaborator

Fixes some bugs with placeholder text being incorrect or placeholder showing when there are torrents

  • Make placeholder stack internal to the TorrentListBox
  • Use set_placeholder to make sure we only show placeholders when the listbox is actually empty
  • Use fewer placeholders and just update the text
  • Fix has_visible_children

@davidmhewitt davidmhewitt merged commit 2e22a8b into main Feb 6, 2023
@davidmhewitt davidmhewitt deleted the listbox-placeholder branch February 6, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants