Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port to Gtk 4 #172

Merged
merged 38 commits into from
Feb 5, 2023
Merged

Port to Gtk 4 #172

merged 38 commits into from
Feb 5, 2023

Conversation

danirabbit
Copy link
Collaborator

@danirabbit danirabbit commented Feb 2, 2023 •
edited
Loading

🎉

danirabbit and others added 30 commits February 1, 2023 16:45
@danirabbit
Initial Gtk 4 porting
f4c109d
@danirabbit
Merge main
605b0f0
@danirabbit
Application focus
cdbbb6d
@danirabbit
more porting
5750499
@danirabbit
Merge branch 'main' into gtk4
0036062
@danirabbit
list row stuff
1803746
@danirabbit
Merge main
ce1ab11
@danirabbit
Smaller diff
bf27f40
@danirabbit
add → append
9abef88
@danirabbit
Merge main
02c5f7f
@danirabbit
Maybe do clipboard things?
9897f26
@danirabbit
Merge main
c9849c4
@danirabbit
Rewrite saved state
43a2772
@danirabbit
delete → close_request
6078828
@danirabbit
hide on close
a03d4e9
@danirabbit
it's a property
2a9899c
@danirabbit
MainWindow: add_files takes SList<File>
0f8015d
@danirabbit
Remove redundant check while here
1c52a52
@danirabbit
MultiInfoBar: subclass box
7140b8e
@danirabbit
TorrentListBox: subclass box
4b227d3
@danirabbit
GObject
c840839
@danirabbit
Merge #186
2e0fb89
@danirabbit
Merge #184
eb0bbdc
@danirabbit
Merge branch 'add-files' into gtk4
84ea35e
@danirabbit
Replace ListBox foreach
d1662e6
@danirabbit
Nearly finish port
45b1f7a
@danirabbit
merge main
6056cc3
@danirabbit
merge main
bb342e2
@davidmhewitt
Add zlib dep
8f99575
@danirabbit
Fix lots of little bugs
954b5a8
@danirabbit danirabbit changed the title Initial Gtk 4 porting Port to Gtk 4 Feb 4, 2023
@danirabbit danirabbit marked this pull request as ready for review February 4, 2023 23:41
davidmhewitt
davidmhewitt approved these changes Feb 5, 2023
View reviewed changes
Copy link
Owner

@davidmhewitt davidmhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm seeing a crash when removing a torrent that I'm not sure whether comes from this branch or is a regression in a previous commit.

But, this is great work, thank you so much ❤️

I'll merge this now and fix up the crash separately 🎉

@davidmhewitt davidmhewitt merged commit 00a31a6 into main Feb 5, 2023
@davidmhewitt davidmhewitt deleted the gtk4 branch February 5, 2023 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidmhewitt davidmhewitt davidmhewitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danirabbit @davidmhewitt