refactor: turn main service into a class again #914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @davidlj95 and the rest of your teammates on |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #914 +/- ##
==========================================
- Coverage 99.45% 99.45% -0.01%
==========================================
Files 79 79
Lines 370 369 -1
Branches 68 68
==========================================
- Hits 368 367 -1
Partials 2 2 ☔ View full report in Codecov by Sentry. |
📦 Bundle size (Angular v18)Git ref:
|
📦 Bundle size (Angular v17)Git ref:
|
📦 Bundle size (Angular v16)Git ref:
|
📦 Bundle size (Angular v15)Git ref:
|
davidlj95
deleted the
stacked/refactor-turn-main-service-into-a-class-again
branch
|
🎉 This PR is included in version 1.0.0-beta.17 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue or need
In #873, the main service
NgxMetaServicewas turned into an abstract class so that it could use a provider to provide the implementation and save a few uncompressed bytes (171 bytes in v18)However, didn't realize that introducing this change would make the service not tree-shakeable. Given when calling
provideNgxMetaCore(or the module-based equivalent API), it would always be provided.Even if unused.
Proposed changes
Turn it back into a service provided in
root. This way it can be removed from the bundle if unused.Other alternatives considered
Turn it into a lazy injection token
It's not something very Angular'ish. At least yet? So for an external API would seem weird to use by a developer.
Keep it as is, service will be used
It is true that the main service will be almost certainly used. Given it's providing the key piece functionality of the library.
So could assume that it will always be used hence no need to provide it in a tree-shakeable manner. And save those 171 bytes.
But a user may only be interested in one of the utils. So allowing tree-shaking could be interesting for those.
Plus this way APIs follow the traditional Angular way of doing things. So less weird things to expect.
Quick reminders