Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: turn default route metadata strategy into provider #912

Conversation

davidlj95
Copy link
Owner

Issue or need

Same as #902 for default route metadata strategy

Proposed changes

Turn default route metadata strategy into a provider so no need to use a non-tree shakeable lazy injection token

Quick reminders

  • 🤝 I will follow Code of Conduct
  • No existing pull request already does almost same changes
  • 👁️ Contributing docs are something I've taken a look at
  • 📝 Commit messages convention has been followed
  • 💬 TSDoc comments have been added or updated indicating API visibility if API surface has changed.
  • 🧪 Tests have been added if needed. For instance, if adding new features or fixing a bug. Or removed if removing features.
  • ⚙️ API Report has been updated if API surface is altered.

Copy link
Owner Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @davidlj95 and the rest of your teammates on Graphite Graphite

Copy link

github-actions bot commented Oct 9, 2024

📦 Bundle size (Angular v18)

Git ref: 1a8853bd2bee3ee4b76112e9807b634b1f9b97a9

Module file Size Base size Difference
ngx-meta-core.mjs 2853 bytes (2.8KiB) 2853 bytes (2.8KiB) No change
ngx-meta-json-ld.mjs 226 bytes (226B) 226 bytes (226B) No change
ngx-meta-open-graph.mjs 986 bytes (986B) 986 bytes (986B) No change
ngx-meta-routing.mjs 408 bytes (408B) 451 bytes (451B) -9.53%: -43 bytes (-43B)
ngx-meta-standard.mjs 994 bytes (994B) 994 bytes (994B) No change
ngx-meta-twitter-card.mjs 514 bytes (514B) 514 bytes (514B) No change
Total 5981 bytes (5.9KiB) 6024 bytes (5.9KiB) -.71%: -43 bytes (-43B)

Copy link

github-actions bot commented Oct 9, 2024

📦 Bundle size (Angular v16)

Git ref: 1a8853bd2bee3ee4b76112e9807b634b1f9b97a9

Module file Size Base size Difference
ngx-meta-core.mjs 3270 bytes (3.2KiB) 3270 bytes (3.2KiB) No change
ngx-meta-json-ld.mjs 370 bytes (370B) 370 bytes (370B) No change
ngx-meta-open-graph.mjs 1265 bytes (1.3KiB) 1265 bytes (1.3KiB) No change
ngx-meta-routing.mjs 598 bytes (598B) 643 bytes (643B) -6.99%: -45 bytes (-45B)
ngx-meta-standard.mjs 1091 bytes (1.1KiB) 1091 bytes (1.1KiB) No change
ngx-meta-twitter-card.mjs 645 bytes (645B) 645 bytes (645B) No change
Total 7239 bytes (7.1KiB) 7284 bytes (7.2KiB) -.61%: -45 bytes (-45B)

Copy link

github-actions bot commented Oct 9, 2024

📦 Bundle size (Angular v15)

Git ref: 1a8853bd2bee3ee4b76112e9807b634b1f9b97a9

Module file Size Base size Difference
ngx-meta-core.mjs 3235 bytes (3.2KiB) 3235 bytes (3.2KiB) No change
ngx-meta-json-ld.mjs 355 bytes (355B) 355 bytes (355B) No change
ngx-meta-open-graph.mjs 1235 bytes (1.3KiB) 1235 bytes (1.3KiB) No change
ngx-meta-routing.mjs 583 bytes (583B) 628 bytes (628B) -7.16%: -45 bytes (-45B)
ngx-meta-standard.mjs 1076 bytes (1.1KiB) 1076 bytes (1.1KiB) No change
ngx-meta-twitter-card.mjs 630 bytes (630B) 630 bytes (630B) No change
Total 7114 bytes (7.0KiB) 7159 bytes (7.0KiB) -.62%: -45 bytes (-45B)

Copy link

github-actions bot commented Oct 9, 2024

📦 Bundle size (Angular v17)

Git ref: 1a8853bd2bee3ee4b76112e9807b634b1f9b97a9

Module file Size Base size Difference
ngx-meta-core.mjs 2853 bytes (2.8KiB) 2853 bytes (2.8KiB) No change
ngx-meta-json-ld.mjs 226 bytes (226B) 226 bytes (226B) No change
ngx-meta-open-graph.mjs 986 bytes (986B) 986 bytes (986B) No change
ngx-meta-routing.mjs 408 bytes (408B) 451 bytes (451B) -9.53%: -43 bytes (-43B)
ngx-meta-standard.mjs 994 bytes (994B) 994 bytes (994B) No change
ngx-meta-twitter-card.mjs 514 bytes (514B) 514 bytes (514B) No change
Total 5981 bytes (5.9KiB) 6024 bytes (5.9KiB) -.71%: -43 bytes (-43B)

@davidlj95 davidlj95 enabled auto-merge (squash) October 9, 2024 22:04
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.45%. Comparing base (26d2300) to head (1a8853b).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #912      +/-   ##
==========================================
- Coverage   99.46%   99.45%   -0.01%     
==========================================
  Files          79       79              
  Lines         372      370       -2     
  Branches       70       69       -1     
==========================================
- Hits          370      368       -2     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidlj95 davidlj95 merged commit 66d5729 into main Oct 9, 2024
34 checks passed
@davidlj95 davidlj95 deleted the stacked/refactor-turn-default-route-metadata-strategy-into-provider branch October 9, 2024 22:04
Copy link

🎉 This PR is included in version 1.0.0-beta.17 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant