-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: turn default route metadata strategy into provider #912
refactor: turn default route metadata strategy into provider #912
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @davidlj95 and the rest of your teammates on |
📦 Bundle size (Angular v18)Git ref:
|
📦 Bundle size (Angular v16)Git ref:
|
📦 Bundle size (Angular v15)Git ref:
|
📦 Bundle size (Angular v17)Git ref:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #912 +/- ##
==========================================
- Coverage 99.46% 99.45% -0.01%
==========================================
Files 79 79
Lines 372 370 -2
Branches 70 69 -1
==========================================
- Hits 370 368 -2
Partials 2 2 ☔ View full report in Codecov by Sentry. |
🎉 This PR is included in version 1.0.0-beta.17 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Issue or need
Same as #902 for default route metadata strategy
Proposed changes
Turn default route metadata strategy into a provider so no need to use a non-tree shakeable lazy injection token
Quick reminders