Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use lazy injection token for metadata resolver #910

Conversation

davidlj95
Copy link
Owner

Issue or need

Same as #902 for metadata resolver

Proposed changes

Same as #902 for metadata resolver

Quick reminders

  • 🀝 I will follow Code of Conduct
  • βœ… No existing pull request already does almost same changes
  • πŸ‘οΈ Contributing docs are something I've taken a look at
  • πŸ“ Commit messages convention has been followed
  • πŸ’¬ TSDoc comments have been added or updated indicating API visibility if API surface has changed.
  • πŸ§ͺ Tests have been added if needed. For instance, if adding new features or fixing a bug. Or removed if removing features.
  • βš™οΈ API Report has been updated if API surface is altered.

Copy link
Owner Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @davidlj95 and the rest of your teammates on Graphite Graphite

Copy link

github-actions bot commented Oct 9, 2024

πŸ“¦ Bundle size (Angular v17)

Git ref: 62bd5d9c4a8a5f0293f4e915abf0130f8ef2edca

Module file Size Base size Difference
ngx-meta-core.mjs 2857 bytes (2.8KiB) 2867 bytes (2.8KiB) -.34%: -10 bytes (-10B)
ngx-meta-json-ld.mjs 226 bytes (226B) 226 bytes (226B) No change
ngx-meta-open-graph.mjs 986 bytes (986B) 986 bytes (986B) No change
ngx-meta-routing.mjs 449 bytes (449B) 449 bytes (449B) No change
ngx-meta-standard.mjs 994 bytes (994B) 994 bytes (994B) No change
ngx-meta-twitter-card.mjs 514 bytes (514B) 514 bytes (514B) No change
Total 6026 bytes (5.9KiB) 6036 bytes (5.9KiB) -.16%: -10 bytes (-10B)

Copy link

github-actions bot commented Oct 9, 2024

πŸ“¦ Bundle size (Angular v15)

Git ref: 62bd5d9c4a8a5f0293f4e915abf0130f8ef2edca

Module file Size Base size Difference
ngx-meta-core.mjs 3239 bytes (3.2KiB) 3261 bytes (3.2KiB) -.67%: -22 bytes (-22B)
ngx-meta-json-ld.mjs 355 bytes (355B) 355 bytes (355B) No change
ngx-meta-open-graph.mjs 1235 bytes (1.3KiB) 1235 bytes (1.3KiB) No change
ngx-meta-routing.mjs 626 bytes (626B) 626 bytes (626B) No change
ngx-meta-standard.mjs 1076 bytes (1.1KiB) 1076 bytes (1.1KiB) No change
ngx-meta-twitter-card.mjs 630 bytes (630B) 630 bytes (630B) No change
Total 7161 bytes (7.0KiB) 7183 bytes (7.1KiB) -.30%: -22 bytes (-22B)

Copy link

github-actions bot commented Oct 9, 2024

πŸ“¦ Bundle size (Angular v16)

Git ref: 62bd5d9c4a8a5f0293f4e915abf0130f8ef2edca

Module file Size Base size Difference
ngx-meta-core.mjs 3274 bytes (3.2KiB) 3296 bytes (3.3KiB) -.66%: -22 bytes (-22B)
ngx-meta-json-ld.mjs 370 bytes (370B) 370 bytes (370B) No change
ngx-meta-open-graph.mjs 1265 bytes (1.3KiB) 1265 bytes (1.3KiB) No change
ngx-meta-routing.mjs 641 bytes (641B) 641 bytes (641B) No change
ngx-meta-standard.mjs 1091 bytes (1.1KiB) 1091 bytes (1.1KiB) No change
ngx-meta-twitter-card.mjs 645 bytes (645B) 645 bytes (645B) No change
Total 7286 bytes (7.2KiB) 7308 bytes (7.2KiB) -.30%: -22 bytes (-22B)

Copy link

github-actions bot commented Oct 9, 2024

πŸ“¦ Bundle size (Angular v18)

Git ref: 62bd5d9c4a8a5f0293f4e915abf0130f8ef2edca

Module file Size Base size Difference
ngx-meta-core.mjs 2857 bytes (2.8KiB) 2867 bytes (2.8KiB) -.34%: -10 bytes (-10B)
ngx-meta-json-ld.mjs 226 bytes (226B) 226 bytes (226B) No change
ngx-meta-open-graph.mjs 986 bytes (986B) 986 bytes (986B) No change
ngx-meta-routing.mjs 449 bytes (449B) 449 bytes (449B) No change
ngx-meta-standard.mjs 994 bytes (994B) 994 bytes (994B) No change
ngx-meta-twitter-card.mjs 514 bytes (514B) 514 bytes (514B) No change
Total 6026 bytes (5.9KiB) 6036 bytes (5.9KiB) -.16%: -10 bytes (-10B)

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 93.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 99.46%. Comparing base (111f6f3) to head (62bd5d9).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
...x-meta/src/core/src/resolvers/metadata-resolver.ts 92.30% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #910      +/-   ##
==========================================
- Coverage   99.46%   99.46%   -0.01%     
==========================================
  Files          79       79              
  Lines         374      373       -1     
  Branches       72       71       -1     
==========================================
- Hits          372      371       -1     
  Partials        2        2              

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@davidlj95 davidlj95 enabled auto-merge (squash) October 9, 2024 21:45
@davidlj95 davidlj95 disabled auto-merge October 9, 2024 21:47
@davidlj95 davidlj95 merged commit 0bc0450 into main Oct 9, 2024
33 of 34 checks passed
@davidlj95 davidlj95 deleted the stacked/refactor-use-lazy-injection-token-for-metadata-resolver branch October 9, 2024 21:48
Copy link

πŸŽ‰ This PR is included in version 1.0.0-beta.17 πŸŽ‰

The release is available on:

Your semantic-release bot πŸ“¦πŸš€

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant