Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use lazy injection token for metadata registry #909

Conversation

davidlj95
Copy link
Owner

Issue or need

Same as #902 for metadata registry

Proposed changes

Same as #902 for metadata registry

Quick reminders

  • 🀝 I will follow Code of Conduct
  • βœ… No existing pull request already does almost same changes
  • πŸ‘οΈ Contributing docs are something I've taken a look at
  • πŸ“ Commit messages convention has been followed
  • πŸ’¬ TSDoc comments have been added or updated indicating API visibility if API surface has changed.
  • πŸ§ͺ Tests have been added if needed. For instance, if adding new features or fixing a bug. Or removed if removing features.
  • βš™οΈ API Report has been updated if API surface is altered.

Copy link
Owner Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @davidlj95 and the rest of your teammates on Graphite Graphite

@davidlj95 davidlj95 force-pushed the stacked/refactor-use-lazy-injection-token-for-metadata-registry branch from 50bc8ee to 8abc1f8 Compare October 9, 2024 21:14
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 99.46%. Comparing base (683d279) to head (8abc1f8).
Report is 10 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #909   +/-   ##
=======================================
  Coverage   99.46%   99.46%           
=======================================
  Files          79       79           
  Lines         373      374    +1     
  Branches       72       72           
=======================================
+ Hits          371      372    +1     
  Partials        2        2           

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

Copy link

github-actions bot commented Oct 9, 2024

πŸ“¦ Bundle size (Angular v17)

Git ref: 8abc1f8599dfee764b41cb849824277eba4961ec

Module file Size Base size Difference
ngx-meta-core.mjs 2867 bytes (2.8KiB) 2875 bytes (2.9KiB) -.27%: -8 bytes (-8B)
ngx-meta-json-ld.mjs 226 bytes (226B) 226 bytes (226B) No change
ngx-meta-open-graph.mjs 986 bytes (986B) 986 bytes (986B) No change
ngx-meta-routing.mjs 449 bytes (449B) 449 bytes (449B) No change
ngx-meta-standard.mjs 994 bytes (994B) 994 bytes (994B) No change
ngx-meta-twitter-card.mjs 514 bytes (514B) 514 bytes (514B) No change
Total 6036 bytes (5.9KiB) 6044 bytes (6.0KiB) -.13%: -8 bytes (-8B)

Copy link

github-actions bot commented Oct 9, 2024

πŸ“¦ Bundle size (Angular v16)

Git ref: 8abc1f8599dfee764b41cb849824277eba4961ec

Module file Size Base size Difference
ngx-meta-core.mjs 3296 bytes (3.3KiB) 3304 bytes (3.3KiB) -.24%: -8 bytes (-8B)
ngx-meta-json-ld.mjs 370 bytes (370B) 370 bytes (370B) No change
ngx-meta-open-graph.mjs 1265 bytes (1.3KiB) 1265 bytes (1.3KiB) No change
ngx-meta-routing.mjs 641 bytes (641B) 641 bytes (641B) No change
ngx-meta-standard.mjs 1091 bytes (1.1KiB) 1091 bytes (1.1KiB) No change
ngx-meta-twitter-card.mjs 645 bytes (645B) 645 bytes (645B) No change
Total 7308 bytes (7.2KiB) 7316 bytes (7.2KiB) -.10%: -8 bytes (-8B)

Copy link

github-actions bot commented Oct 9, 2024

πŸ“¦ Bundle size (Angular v15)

Git ref: 8abc1f8599dfee764b41cb849824277eba4961ec

Module file Size Base size Difference
ngx-meta-core.mjs 3261 bytes (3.2KiB) 3269 bytes (3.2KiB) -.24%: -8 bytes (-8B)
ngx-meta-json-ld.mjs 355 bytes (355B) 355 bytes (355B) No change
ngx-meta-open-graph.mjs 1235 bytes (1.3KiB) 1235 bytes (1.3KiB) No change
ngx-meta-routing.mjs 626 bytes (626B) 626 bytes (626B) No change
ngx-meta-standard.mjs 1076 bytes (1.1KiB) 1076 bytes (1.1KiB) No change
ngx-meta-twitter-card.mjs 630 bytes (630B) 630 bytes (630B) No change
Total 7183 bytes (7.1KiB) 7191 bytes (7.1KiB) -.11%: -8 bytes (-8B)

Copy link

github-actions bot commented Oct 9, 2024

πŸ“¦ Bundle size (Angular v18)

Git ref: 8abc1f8599dfee764b41cb849824277eba4961ec

Module file Size Base size Difference
ngx-meta-core.mjs 2867 bytes (2.8KiB) 2875 bytes (2.9KiB) -.27%: -8 bytes (-8B)
ngx-meta-json-ld.mjs 226 bytes (226B) 226 bytes (226B) No change
ngx-meta-open-graph.mjs 986 bytes (986B) 986 bytes (986B) No change
ngx-meta-routing.mjs 449 bytes (449B) 449 bytes (449B) No change
ngx-meta-standard.mjs 994 bytes (994B) 994 bytes (994B) No change
ngx-meta-twitter-card.mjs 514 bytes (514B) 514 bytes (514B) No change
Total 6036 bytes (5.9KiB) 6044 bytes (6.0KiB) -.13%: -8 bytes (-8B)

@davidlj95 davidlj95 enabled auto-merge (squash) October 9, 2024 21:30
@davidlj95 davidlj95 disabled auto-merge October 9, 2024 21:37
@davidlj95 davidlj95 merged commit 111f6f3 into main Oct 9, 2024
32 checks passed
@davidlj95 davidlj95 deleted the stacked/refactor-use-lazy-injection-token-for-metadata-registry branch October 9, 2024 21:38
Copy link

πŸŽ‰ This PR is included in version 1.0.0-beta.17 πŸŽ‰

The release is available on:

Your semantic-release bot πŸ“¦πŸš€

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant