Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: allow lazy injection tokens not to provide a factory #907

Conversation

davidlj95
Copy link
Owner

Issue or need

About to use a lazy injection token for the DEFAULTS token. But in there, no factory is needed. However, the current util function requires one.

Proposed changes

Allows util to make lazy injection tokens to create tokens without factories. Useful in the following PR's case.

Quick reminders

  • 🤝 I will follow Code of Conduct
  • No existing pull request already does almost same changes
  • 👁️ Contributing docs are something I've taken a look at
  • 📝 Commit messages convention has been followed
  • 💬 TSDoc comments have been added or updated indicating API visibility if API surface has changed.
  • 🧪 Tests have been added if needed. For instance, if adding new features or fixing a bug. Or removed if removing features.
  • ⚙️ API Report has been updated if API surface is altered.

@davidlj95 davidlj95 enabled auto-merge (squash) October 9, 2024 15:34
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.46%. Comparing base (23abd03) to head (ea25aaa).
Report is 12 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #907   +/-   ##
=======================================
  Coverage   99.46%   99.46%           
=======================================
  Files          79       79           
  Lines         373      373           
  Branches       72       72           
=======================================
  Hits          371      371           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidlj95 davidlj95 force-pushed the stacked/refactor-allow-lazy-injection-tokens-not-to-provide-a-factory branch from f94cb68 to 22a3b27 Compare October 9, 2024 15:42
Copy link
Owner Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @davidlj95 and the rest of your teammates on Graphite Graphite

@davidlj95 davidlj95 force-pushed the stacked/refactor-allow-lazy-injection-tokens-not-to-provide-a-factory branch from 22a3b27 to ea25aaa Compare October 9, 2024 15:50
@davidlj95 davidlj95 merged commit 2d572b7 into main Oct 9, 2024
34 checks passed
@davidlj95 davidlj95 deleted the stacked/refactor-allow-lazy-injection-tokens-not-to-provide-a-factory branch October 9, 2024 15:54
Copy link

github-actions bot commented Oct 9, 2024

📦 Bundle size (Angular v15)

Git ref: ea25aaa632d3da014d2783674d313f791bce6620

Module file Size Base size Difference
ngx-meta-core.mjs 3271 bytes (3.2KiB) 3262 bytes (3.2KiB) .27%: 9 bytes (9B)
ngx-meta-json-ld.mjs 355 bytes (355B) 355 bytes (355B) No change
ngx-meta-open-graph.mjs 1235 bytes (1.3KiB) 1235 bytes (1.3KiB) No change
ngx-meta-routing.mjs 626 bytes (626B) 626 bytes (626B) No change
ngx-meta-standard.mjs 1076 bytes (1.1KiB) 1076 bytes (1.1KiB) No change
ngx-meta-twitter-card.mjs 630 bytes (630B) 630 bytes (630B) No change
Total 7193 bytes (7.1KiB) 7184 bytes (7.1KiB) .12%: 9 bytes (9B)

Copy link

github-actions bot commented Oct 9, 2024

📦 Bundle size (Angular v16)

Git ref: ea25aaa632d3da014d2783674d313f791bce6620

Module file Size Base size Difference
ngx-meta-core.mjs 3306 bytes (3.3KiB) 3297 bytes (3.3KiB) .27%: 9 bytes (9B)
ngx-meta-json-ld.mjs 370 bytes (370B) 370 bytes (370B) No change
ngx-meta-open-graph.mjs 1265 bytes (1.3KiB) 1265 bytes (1.3KiB) No change
ngx-meta-routing.mjs 641 bytes (641B) 641 bytes (641B) No change
ngx-meta-standard.mjs 1091 bytes (1.1KiB) 1091 bytes (1.1KiB) No change
ngx-meta-twitter-card.mjs 645 bytes (645B) 645 bytes (645B) No change
Total 7318 bytes (7.2KiB) 7309 bytes (7.2KiB) .12%: 9 bytes (9B)

Copy link

github-actions bot commented Oct 9, 2024

📦 Bundle size (Angular v17)

Git ref: ea25aaa632d3da014d2783674d313f791bce6620

Module file Size Base size Difference
ngx-meta-core.mjs 2877 bytes (2.9KiB) 2868 bytes (2.9KiB) .31%: 9 bytes (9B)
ngx-meta-json-ld.mjs 226 bytes (226B) 226 bytes (226B) No change
ngx-meta-open-graph.mjs 986 bytes (986B) 986 bytes (986B) No change
ngx-meta-routing.mjs 449 bytes (449B) 449 bytes (449B) No change
ngx-meta-standard.mjs 994 bytes (994B) 994 bytes (994B) No change
ngx-meta-twitter-card.mjs 514 bytes (514B) 514 bytes (514B) No change
Total 6046 bytes (6.0KiB) 6037 bytes (5.9KiB) .14%: 9 bytes (9B)

Copy link

github-actions bot commented Oct 9, 2024

📦 Bundle size (Angular v18)

Git ref: ea25aaa632d3da014d2783674d313f791bce6620

Module file Size Base size Difference
ngx-meta-core.mjs 2877 bytes (2.9KiB) 2868 bytes (2.9KiB) .31%: 9 bytes (9B)
ngx-meta-json-ld.mjs 226 bytes (226B) 226 bytes (226B) No change
ngx-meta-open-graph.mjs 986 bytes (986B) 986 bytes (986B) No change
ngx-meta-routing.mjs 449 bytes (449B) 449 bytes (449B) No change
ngx-meta-standard.mjs 994 bytes (994B) 994 bytes (994B) No change
ngx-meta-twitter-card.mjs 514 bytes (514B) 514 bytes (514B) No change
Total 6046 bytes (6.0KiB) 6037 bytes (5.9KiB) .14%: 9 bytes (9B)

Copy link

🎉 This PR is included in version 1.0.0-beta.17 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant