-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: allow lazy injection tokens not to provide a factory #907
refactor: allow lazy injection tokens not to provide a factory #907
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #907 +/- ##
=======================================
Coverage 99.46% 99.46%
=======================================
Files 79 79
Lines 373 373
Branches 72 72
=======================================
Hits 371 371
Partials 2 2 ☔ View full report in Codecov by Sentry. |
f94cb68
to
22a3b27
Compare
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @davidlj95 and the rest of your teammates on |
22a3b27
to
ea25aaa
Compare
📦 Bundle size (Angular v15)Git ref:
|
📦 Bundle size (Angular v16)Git ref:
|
📦 Bundle size (Angular v17)Git ref:
|
📦 Bundle size (Angular v18)Git ref:
|
🎉 This PR is included in version 1.0.0-beta.17 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Issue or need
About to use a lazy injection token for the
DEFAULTS
token. But in there, no factory is needed. However, the current util function requires one.Proposed changes
Allows util to make lazy injection tokens to create tokens without factories. Useful in the following PR's case.
Quick reminders