Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use lazy injection token for url resolver #906

Merged

Conversation

davidlj95
Copy link
Owner

Issue or need

Same as #902 for URL resolver

Proposed changes

Same as #902 for URL resolver

Quick reminders

  • 🀝 I will follow Code of Conduct
  • βœ… No existing pull request already does almost same changes
  • πŸ‘οΈ Contributing docs are something I've taken a look at
  • πŸ“ Commit messages convention has been followed
  • πŸ’¬ TSDoc comments have been added or updated indicating API visibility if API surface has changed.
  • πŸ§ͺ Tests have been added if needed. For instance, if adding new features or fixing a bug. Or removed if removing features.
  • βš™οΈ API Report has been updated if API surface is altered.

Copy link
Owner Author

davidlj95 commented Oct 9, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @davidlj95 and the rest of your teammates on Graphite Graphite

Copy link

github-actions bot commented Oct 9, 2024

πŸ“¦ Bundle size (Angular v15)

Git ref: 239b8da90a8d87907523573d8e2318e041aa5dbf

Module file Size Base size Difference
ngx-meta-core.mjs 3262 bytes (3.2KiB) 3276 bytes (3.2KiB) -.42%: -14 bytes (-14B)
ngx-meta-json-ld.mjs 355 bytes (355B) 355 bytes (355B) No change
ngx-meta-open-graph.mjs 1235 bytes (1.3KiB) 1233 bytes (1.3KiB) .16%: 2 bytes (2B)
ngx-meta-routing.mjs 626 bytes (626B) 626 bytes (626B) No change
ngx-meta-standard.mjs 1076 bytes (1.1KiB) 1074 bytes (1.1KiB) .18%: 2 bytes (2B)
ngx-meta-twitter-card.mjs 630 bytes (630B) 630 bytes (630B) No change
Total 7184 bytes (7.1KiB) 7194 bytes (7.1KiB) -.13%: -10 bytes (-10B)

Copy link

github-actions bot commented Oct 9, 2024

πŸ“¦ Bundle size (Angular v18)

Git ref: 239b8da90a8d87907523573d8e2318e041aa5dbf

Module file Size Base size Difference
ngx-meta-core.mjs 2868 bytes (2.9KiB) 2882 bytes (2.9KiB) -.48%: -14 bytes (-14B)
ngx-meta-json-ld.mjs 226 bytes (226B) 226 bytes (226B) No change
ngx-meta-open-graph.mjs 986 bytes (986B) 984 bytes (984B) .20%: 2 bytes (2B)
ngx-meta-routing.mjs 449 bytes (449B) 449 bytes (449B) No change
ngx-meta-standard.mjs 994 bytes (994B) 992 bytes (992B) .20%: 2 bytes (2B)
ngx-meta-twitter-card.mjs 514 bytes (514B) 514 bytes (514B) No change
Total 6037 bytes (5.9KiB) 6047 bytes (6.0KiB) -.16%: -10 bytes (-10B)

Copy link

github-actions bot commented Oct 9, 2024

πŸ“¦ Bundle size (Angular v16)

Git ref: 239b8da90a8d87907523573d8e2318e041aa5dbf

Module file Size Base size Difference
ngx-meta-core.mjs 3297 bytes (3.3KiB) 3311 bytes (3.3KiB) -.42%: -14 bytes (-14B)
ngx-meta-json-ld.mjs 370 bytes (370B) 370 bytes (370B) No change
ngx-meta-open-graph.mjs 1265 bytes (1.3KiB) 1263 bytes (1.3KiB) .15%: 2 bytes (2B)
ngx-meta-routing.mjs 641 bytes (641B) 641 bytes (641B) No change
ngx-meta-standard.mjs 1091 bytes (1.1KiB) 1089 bytes (1.1KiB) .18%: 2 bytes (2B)
ngx-meta-twitter-card.mjs 645 bytes (645B) 645 bytes (645B) No change
Total 7309 bytes (7.2KiB) 7319 bytes (7.2KiB) -.13%: -10 bytes (-10B)

Copy link

github-actions bot commented Oct 9, 2024

πŸ“¦ Bundle size (Angular v17)

Git ref: 239b8da90a8d87907523573d8e2318e041aa5dbf

Module file Size Base size Difference
ngx-meta-core.mjs 2868 bytes (2.9KiB) 2882 bytes (2.9KiB) -.48%: -14 bytes (-14B)
ngx-meta-json-ld.mjs 226 bytes (226B) 226 bytes (226B) No change
ngx-meta-open-graph.mjs 986 bytes (986B) 984 bytes (984B) .20%: 2 bytes (2B)
ngx-meta-routing.mjs 449 bytes (449B) 449 bytes (449B) No change
ngx-meta-standard.mjs 994 bytes (994B) 992 bytes (992B) .20%: 2 bytes (2B)
ngx-meta-twitter-card.mjs 514 bytes (514B) 514 bytes (514B) No change
Total 6037 bytes (5.9KiB) 6047 bytes (6.0KiB) -.16%: -10 bytes (-10B)

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 99.46%. Comparing base (259fb02) to head (239b8da).
Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #906      +/-   ##
==========================================
- Coverage   99.46%   99.46%   -0.01%     
==========================================
  Files          79       79              
  Lines         374      373       -1     
  Branches       73       72       -1     
==========================================
- Hits          372      371       -1     
  Partials        2        2              

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@davidlj95 davidlj95 merged commit 23abd03 into main Oct 9, 2024
34 checks passed
@davidlj95 davidlj95 deleted the stacked/refactor-use-lazy-injection-token-for-url-resolver branch October 9, 2024 15:32
Copy link

πŸŽ‰ This PR is included in version 1.0.0-beta.17 πŸŽ‰

The release is available on:

Your semantic-release bot πŸ“¦πŸš€

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant