chore: add util to make (lazy) injection tokens #892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @davidlj95 and the rest of your teammates on |
davidlj95
force-pushed
the
stacked/chore-add-util-to-make-lazy-injection-tokens
branch
from
7075f97 to
3f13756
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #892 +/- ##
=======================================
Coverage 99.45% 99.46%
=======================================
Files 78 79 +1
Lines 366 372 +6
Branches 72 73 +1
=======================================
+ Hits 364 370 +6
Partials 2 2 ☔ View full report in Codecov by Sentry. |
📦 Bundle size (Angular v17)Git ref:
|
📦 Bundle size (Angular v16)Git ref:
|
📦 Bundle size (Angular v15)Git ref:
|
📦 Bundle size (Angular v18)Git ref:
|
davidlj95
force-pushed
the
stacked/chore-add-util-to-make-lazy-injection-tokens
branch
3 times, most recently
from
be8c706 to
5163a0e
Compare
davidlj95
force-pushed
the
stacked/chore-add-util-to-make-lazy-injection-tokens
branch
from
5163a0e to
7449f99
Compare
davidlj95
deleted the
stacked/chore-add-util-to-make-lazy-injection-tokens
branch
|
🎉 This PR is included in version 1.0.0-beta.16 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue or need
See #891
Proposed changes
Add a util to define injection tokens & its factories in a lazy manner. This way, if no one needs them, they won't be created. Neither their factories will end up in the production bundle.
Came with this APIs eventually, though first iteration was
<T>(...args: ConstructorParameters<InjectionToken<T>>) => InjectionToken<T>. Then, thought that maybe could uncouple to the parameters of theInjectionToken. So went with<T>(injectionTokenFactory: () => InjectionToken<T>) => T. But then when using the API, we're adding yet another level of indent. Finally, thought that we're also addingNgxMetaaround in our injection tokens. If we supplied the name here, we could avoid repeating that string around. Plus save the{ factory: [...] }object declaration around. So here it is. Tried it a bit with_HEAD_ELEMENT_UPSERT_OR_REMOVE. Works fine.The name went from
lazyInjectionTokentomakeInjectionTokengiven it also adds the library prefix to the injection token name now.Quick reminders