test: standard theme color metadata setting two metas #881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @davidlj95 and the rest of your teammates on |
davidlj95
force-pushed
the
stacked/fix-standard-theme-color-metadata-can-t-set-two-metas
branch
from
7f11b44 to
bbe366a
Compare
davidlj95
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #881 +/- ##
=======================================
Coverage 98.14% 98.14%
=======================================
Files 83 83
Lines 377 377
Branches 70 70
=======================================
Hits 370 370
Misses 3 3
Partials 4 4 ☔ View full report in Codecov by Sentry. |
📦 Bundle size (Angular v16)Git ref:
|
📦 Bundle size (Angular v18)Git ref:
|
📦 Bundle size (Angular v15)Git ref:
|
📦 Bundle size (Angular v17)Git ref:
|
davidlj95
force-pushed
the
stacked/fix-standard-theme-color-metadata-can-t-set-two-metas
branch
from
bbe366a to
a82990b
Compare
davidlj95
deleted the
stacked/fix-standard-theme-color-metadata-can-t-set-two-metas
branch
|
🎉 This PR is included in version 1.0.0-beta.19 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue or need
After trying to rebuild the APIs to set
<meta>elements on the page (NgxMetaMetaService,NgxMetaMetaDefinition, ...), inspected how Angular'sMetaAPIs workAnd at that point in time wondered what happens with the case that more than one multiple
<meta>element with samenameis valid. Like in the case of standard's<meta name='theme-color'>.So added some E2E tests to see what happens when trying to add 2
<meta name='theme-color'>. One for dark mode and another for the default (light) mode.Turns out that the API wasn't working as intended when trying to insert more than one
<meta>. 2 elements are expected if providing an array with two elements.However just one is created and later updated. Which makes sense given we call Angular's
Meta.updateTagAPI.Proposed changes
Add E2E tests to reflect the issue & avoid it from happening in the future.
In #919 new APIs to manage
<meta>elements are used around. So this should fix the issue. Adding here the tests then to ensure it doesn't repeat again.Quick reminders