Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Autoplay and AutoScroll not destroyed properly #750

Closed
5 of 14 tasks
davidjerleke opened this issue Feb 20, 2024 · 0 comments · Fixed by #751
Closed
5 of 14 tasks

[Bug]: Autoplay and AutoScroll not destroyed properly #750

davidjerleke opened this issue Feb 20, 2024 · 0 comments · Fixed by #751
Assignees
@davidjerleke
Labels
bug Something isn't working plugin Issue is related to plugins resolved This issue is resolved

Comments

@davidjerleke
Copy link
Owner

Which variants of Embla Carousel are you using?

  • embla-carousel (Core)
  • embla-carousel-react
  • embla-carousel-vue
  • embla-carousel-svelte
  • embla-carousel-autoplay
  • embla-carousel-auto-scroll
  • embla-carousel-solid
  • embla-carousel-auto-height
  • embla-carousel-class-names
  • embla-carousel-docs (Documentation)
  • embla-carousel-docs (Generator)

Steps to reproduce

The bug can be reproduced when resizing the carousel. After that the calculations are wrong because the destroy functions in both plugins don't cleanup properly.

Expected Behavior

The destroy functions in both plugins should cleanup properly.

Additional Context

2024-02-09.14-57-53.mp4

What browsers are you seeing the problem on?

No response

Version

v8.0.0-rc23

CodeSandbox

https://codesandbox.io/p/sandbox/embla-carousel-drag-free-react-forked-x3svqx

Before submitting

  • I've made research efforts and searched the documentation
  • I've searched for existing issues
  • I agree to follow this project's Contributing Guidelines for bug reports
@davidjerleke davidjerleke added the bug Something isn't working label Feb 20, 2024
@davidjerleke davidjerleke self-assigned this Feb 20, 2024
davidjerleke added a commit that referenced this issue Feb 20, 2024
@davidjerleke
Bug fix for #750.
44cc2ca
@davidjerleke davidjerleke mentioned this issue Feb 20, 2024
Merged
davidjerleke added a commit that referenced this issue Feb 20, 2024
@davidjerleke
Merge pull request #751 from davidjerleke/bug/#750
0926b15 
[Bug]: Autoplay and AutoScroll not destroyed properly
@davidjerleke davidjerleke added the resolved This issue is resolved label Feb 20, 2024
@davidjerleke davidjerleke added the plugin Issue is related to plugins label Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidjerleke davidjerleke

Labels
bug Something isn't working plugin Issue is related to plugins resolved This issue is resolved
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Bug]: Autoplay and AutoScroll not destroyed properly davidjerleke/embla-carousel
1 participant
@davidjerleke