-
-
Notifications
You must be signed in to change notification settings - Fork 983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Infinite resizing of iframe #7
Comments
Happy to take a pull request if you have a moment to look at that. |
Fixed in v1.1 |
David hi, I’m preparing larger update on my fork, I will notify you on update. Jure On 23. jan. 2014, at 19:39, David J. Bradshaw notifications@github.com wrote:
|
Ok cool I just published a new version that uses mutationobserver to detect What are you working on? Dave. On Thursday, January 23, 2014, Jure notifications@github.com wrote:
David J. Bradshaw )'( dave@bradshaw.net |
Change: previously loading & initializing of “iframe-resizer” plugin was made inside body tag, now the plugin can be defined in head tag and will be automatically initialized on jQuery document.ready event On 23. jan. 2014, at 22:08, David J. Bradshaw notifications@github.com wrote:
|
Sounds good, only thing I ask is the iFrame code has no dependancies, as On Thursday, January 23, 2014, Jure notifications@github.com wrote:
David J. Bradshaw )'( dave@bradshaw.net |
Sure, I did have problem with that, just added init retry methods. J
|
Please - merge it https://github.com/jmav/iframe-resizer On 24. jan. 2014, at 00:40, David J. Bradshaw notifications@github.com wrote:
|
Hi you will need to make a pull request on GitHub for me to be able to do a Having had a quick look at the code, I'm not sure why the iframe needs the Also not clear why the retryPostInitMessagetoIframe() function is needed. Happy to add the autoWindowResize flag. I think it needs to override the Also your version of setHeightAuto is better than my one, as I forgot to So if you could make a github pull request with the autoWindowResize flag Also I'd rather leave the code at the bottom of the HTML, as this is best Cheers, On Fri, Jan 24, 2014 at 2:50 AM, Jure notifications@github.com wrote:
David J. Bradshaw )'( dave@bradshaw.net |
Hey, just had a chance to read through the other stuff you did and want to say Can you send a pull request please. D. On Fri, Jan 24, 2014 at 12:23 PM, Dave Bradshaw
David J. Bradshaw )'( dave@bradshaw.net |
Done On 27. jan. 2014, at 11:09, David J. Bradshaw notifications@github.com wrote:
|
Instead of initialization retry method I would use trigger from iframe, but problem is in unique identifier. I would be neat solution. J
|
If body has style
height: 100%
iframe is increasing it's height by few pixels.Solution:
Preventive add style
height: auto
to body tag.The text was updated successfully, but these errors were encountered: