Skip to content

Commit

Permalink
fix(docs): fix package id links in docs
Browse files Browse the repository at this point in the history
These were previously being rendered via esdoc (which uses marked's
autolink rendering) as `mailto:` links.  There are some
[suggestions](https://gist.github.com/alexpeattie/4729247) about how one
might disable or avoid autolinking but in this case the package
identifiers are in backticks, producing weird behaviour similar to
markedjs/marked#1327.

Assuming the fix attached to this latter issue applied in this case,
then a dependency upgrade of `marked` within `esdoc` might solve the
problem, but there are [maintenance
issues](esdoc/esdoc#543) there.

Until that arrives, this is a workaround to avoiding the weird `mailto:`
links on this page.
  • Loading branch information
davidjb committed Oct 2, 2019
1 parent 7a90df5 commit ee169a1
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions docs/manual/upgrade-to-v5.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ Sequelize now ship official typings [#10287](https://github.com/sequelize/sequel

### Pooling

With v5 Sequelize now use `sequelize-pool` which is a modernized fork of `generic-pool@2.5`. You no longer need to call `sequelize.close` to shutdown pool, this helps with lambda executions. [#8468](https://github.com/sequelize/sequelize/issues/8468)
With v5 Sequelize now use `sequelize-pool` which is a modernized fork of <code>generic-pool&#64;2.5</code>. You no longer need to call `sequelize.close` to shutdown pool, this helps with lambda executions. [#8468](https://github.com/sequelize/sequelize/issues/8468)

### Model

Expand Down Expand Up @@ -231,7 +231,7 @@ dialectOptions: {
- fix(types): additional options for db.query and add missing retry [#10512](https://github.com/sequelize/sequelize/pull/10512)
- fix(query): don't prepare options & sql for every retry [#10498](https://github.com/sequelize/sequelize/pull/10498)
- feat: expose Sequelize.BaseError
- feat: upgrade to tedious@6.0.0 [#10494](https://github.com/sequelize/sequelize/pull/10494)
- feat: upgrade to <code>tedious&#64;6.0.0</code> [#10493](https://github.com/sequelize/sequelize/pull/10494)
- feat(sqlite/query-generator): support restart identity for truncate-table [#10522](https://github.com/sequelize/sequelize/pull/10522)
- feat(data-types): handle numbers passed as objects [#10492](https://github.com/sequelize/sequelize/pull/10492)
- feat(types): enabled string association [#10481](https://github.com/sequelize/sequelize/pull/10481)
Expand Down

0 comments on commit ee169a1

Please sign in to comment.