Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StickyHeadersHelper fix #116

Merged
merged 1 commit into from
Jun 18, 2016
Merged

StickyHeadersHelper fix #116

merged 1 commit into from
Jun 18, 2016

Conversation

zoopolitic
Copy link
Contributor

  • fixed bug with header translation when child has height/width < height/width of it's header

@davideas davideas merged commit 6c35a4d into davideas:dev Jun 18, 2016
@davideas
Copy link
Owner

davideas commented Jun 18, 2016 •
edited
Loading

@zoopolitic, why childIsSmallerThanHeader() should be necessary? everything works fine without it, without that if.

@zoopolitic
Copy link
Contributor Author

Just check it. Yes, you're right, with for loop starting with 0 this check is unnecessary, it was fixing my issue with reversed for loop. So 'if' can be removed.

davideas added a commit that referenced this pull request Jun 18, 2016
@davideas
Optimized fix for pull request #116
afa159a
@davideas davideas mentioned this pull request Jun 18, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zoopolitic @davideas