Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hints not being shown with new color spaces in CSS Colors v4 #257

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

david-tejada
Copy link
Owner

This pull request fixes the error when we encounter a color that it's not in RGB space, like lch, lab, ... It still doesn't handle colors appropriately but it will default to white background and black text.

Copy link

netlify bot commented Dec 7, 2023

Deploy Preview for voluble-crisp-6e2a75 ready!

Name Link
🔨 Latest commit 36af841
🔍 Latest deploy log https://app.netlify.com/sites/voluble-crisp-6e2a75/deploys/6571c80777cae300083393aa
😎 Deploy Preview https://deploy-preview-257--voluble-crisp-6e2a75.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@david-tejada david-tejada merged commit c3de2fa into main Dec 7, 2023
6 checks passed
@david-tejada david-tejada deleted the fix-colors branch December 7, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant