Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ellipse primitive #45

Merged
merged 3 commits into from
Sep 26, 2024
Merged

Ellipse primitive #45

merged 3 commits into from
Sep 26, 2024

Conversation

davibarreira
Copy link
Owner

Implemented the ellipse primitive. The name of the branch is misleading.

Copy link

codecov bot commented Sep 26, 2024

Codecov Report

Attention: Patch coverage is 43.33333% with 17 lines in your changes missing coverage. Please review.

Project coverage is 72.00%. Comparing base (927e709) to head (9ea18ba).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
src/auxiliar/normalize.jl 0.00% 7 Missing ⚠️
src/primitives/ellipse.jl 33.33% 4 Missing ⚠️
src/auxiliar/auxiliary_geometric_functions.jl 0.00% 3 Missing ⚠️
src/backends/svgbackend.jl 40.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #45      +/-   ##
==========================================
- Coverage   72.32%   72.00%   -0.32%     
==========================================
  Files          69       70       +1     
  Lines        2414     2440      +26     
==========================================
+ Hits         1746     1757      +11     
- Misses        668      683      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davibarreira davibarreira merged commit 0898fef into master Sep 26, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant