💥 Update ALL remaining roles to new format (with docs and tests)

[anarion80]

What this PR does / why we need it:

As in the title: I updated all the remaining roles to new format - adding docs and molecule tests. I know this doesn't really adhere to your contributing guideline, but you're probably busy, PR intake is slow, so here it is.

While creating passing tests I had to fix some roles:

• Krusader had old, non-existent image
• Nomad needed gpg key update
• Timemachine needed apt cache update
• Wallabag needed additional directories created with certain permissions (can be a bug in Wallabag currently)
• ZNC needed a starting config file as it was interactive and thus not easy to automate testing for

From the general things:

• Fixed lint
• Moved from deprecated links to networks for certain roles
• Added variables for container image names:versions instead of hardcoding in tasks
• Updated Ansible module names to use fully qualified collection name (FQCN)

All passing tests are here: https://github.com/anarion80/ansible-nas/actions/runs/4392401003

Which issue (if any) this PR fixes:

Fixes #

Any other useful info:

[davestephens]

Wow, this is amazing, thank you!

I'll start reviewing this week, hopefully won't take too long to get merged.

[davestephens]

This looks great, thank you for taking the time!

Few comments;

• all of the doc moves have been dragged and dropped rather than git mv ...., which means the files are showing as new additions, and we lose the history.
• the roles I'd already rejigged are missing the new docker settings - these are a nice addition so would be good to add
• the docs generation doesn't currently cater for docs within the role directories, so will need some shell scripting to set up (or the docs be left in their original location for now).

[anarion80]

all of the doc moves have been dragged and dropped rather than git mv ...., which means the files are showing as new additions, and we lose the history.

Do you mean moves of existing docs from website into roles? If so - yes, I can remove then, do git mv ... and update if necessary.

the roles I'd already rejigged are missing the new docker settings - these are a nice addition so would be good to add

Which setting do you mean exactly?

the docs generation doesn't currently cater for docs within the role directories, so will need some shell scripting to set up (or the docs be left in their original location for now)

Yes, so the docs are left in their original settings (when I add new roles for myself I add docs to both locations for now), and in new roles location - just to be consistent with hello_world example and ready for any future script updates.

[anarion80]

Ok, I think it should be rather git cp .. still, not mv, since I just followed to convention and did not attempt to MOVE all the docs storing and generation to /docs folders. For now at least.

[anarion80]

Well, I copied the files using git-cp which was supposed to copy git history, but I don't see that git history :/

[davestephens]

Well, I copied the files using git-cp which was supposed to copy git history, but I don't see that git history :/

Ah, that makes sense why they are showing as new files. I think it'll end up as a management nightmare having two copies of the docs - so please can we remove the new copies and leave the docs where they were originally. Once I get to sorting out the docs generation I can move them into the roles again!

[anarion80]

Ok, I removed the new/individual docs, and also rebased to upstream

[davestephens]

Finally got this one merged - thanks for your efforts - I also did a fair bit of extra work on it :)

Also - the following tests aren't passing:

FAILED roles/joomla/molecule/default/molecule.yml::test
FAILED roles/nextcloud/molecule/default/molecule.yml::test
FAILED roles/openhab/molecule/default/molecule.yml::test
FAILED roles/piwigo/molecule/default/molecule.yml::test
FAILED roles/transmission-with-openvpn/molecule/default/molecule.yml::test
FAILED roles/virtual_desktop/molecule/default/molecule.yml::test

It seems that they are all roles that have been flipped to creating a network over the legacy link method. Did you see this in testing?

[anarion80]

Thanks! Yes, I fillpped them over to the new method over deprecated link method.
I quickly checked the first two roles on new_format branch and they are passing tests all right.
I will rebase my master and check there.

[davestephens]

Interestingly they pass on GitHub, but fail locally. I'll do some more digging!

…

On Wed, 19 Apr 2023, 07:22 Anarion, ***@***.***> wrote: Thanks! Yes, I fillpped them over to the new method over deprecated link method. I quickly checked the first two roles on new_format branch and they are passing tests all right. I will rebase my master and check there. — Reply to this email directly, view it on GitHub <#655 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAFDGMEC4RGGB2VZS4TFGXDXB6AAXANCNFSM6AAAAAAVXP5TF4> . You are receiving this because you modified the open/close state.Message ID: ***@***.***>