-
-
Notifications
You must be signed in to change notification settings - Fork 495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: ADDITION: Pi-hole #321
base: main
Are you sure you want to change the base?
Conversation
I think I fixed the merge errors adding in the Organizr references, but evidently GH doesn't automatically re-test and I can't mark resolved. |
@bcurran3 this is great! can't wait to get this :) |
Thanks. It works well. Dave appears to be very busy in real life and is only popping his head in randomly. So it might be awhile until this is added... (plus I should automate what I'm about to say next:) You should be able to copy and paste it into your existing setup easily. You'll just want to do: REF: https://www.smarthomebeginner.com/run-pihole-in-docker-on-ubuntu-with-reverse-proxy/ I've got something else very cool on the back-burner waiting for the PRs to catch up since it is a global change and will be a big addition to remote/local security. |
For those who don't want to 1> wait for this to be merged 2> copy and paste it in their own files.... Check this out!: I'm actually test using it now. Pretty cool running an ad-blocker in Google's cloud. |
@@ -36,6 +36,14 @@ | |||
when: (traefik_enabled | default(False)) | |||
tags: traefik | |||
|
|||
- import_tasks: tasks/pihole_with_traefik.yml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing indentation, build fails due to invalid yaml
@bcurran3 I gave you a PR which adds the missing dns resolver configuration (https://github.com/bcurran3/ansible-nas/pull/1/files) so we can hopefully integrate it in the PR here. |
@random-dwi Thanks. On my TDL to look at and compare to what I've done too. |
This article might be of interest: the solution suggested was to expose the ip address and port of the pi-hole container to ensure that other containers route through the pi-hole container. I have pi-hole installed on the bare-metal pi-hole, so I haven't tested this yet, but there are several reports of success pi-hole/docker-pi-hole#1166 (comment) |
@brock As I recently tested other dns server the same problem occurred I can confirm that this approach is working. I'm planning to move to pihole so I will confirm here as well. |
What this PR does / why we need it:
Adds Pi-hole
Which issue (if any) this PR fixes:
Fixes # #147
Any other useful info:
!!- WORK IN PROGRESS -!!
- Reference article: Step 0I'm open to suggestions on how to automate the prerequisites.
I think checking if either option of Pi-hole is enabled and pulling the docker container is easy enough and I'll prolly add in the near future.Stopping the resolver and modifying the config will require more time (debugging in a VM!) to accomplish and I'd be very amicable if someone else wants to pop that part into this.EDIT: "Step 0" done