Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rh, rap, nl to Aedes #24

Merged
merged 1 commit into from
May 6, 2022
Merged

Add rh, rap, nl to Aedes #24

merged 1 commit into from
May 6, 2022

Conversation

oldrich-s
Copy link
Contributor

@oldrich-s oldrich-s commented May 6, 2022

Hi,

I am working on fixing Aedes bridge connection where nl flag is not respected:

moscajs/aedes#736

For that I need to update qlobber to work with nl, rap and rh flags.

I have made the changes as seen in this pull request.

When I run npm run test the native Aedes tests fail:

image

Any idea how to make them not to fail?

PS: I am using gitpoid.io to make changes and run tests as I have no Linux machine at hand.

@davedoesdev
Copy link
Owner

@oldrich-s I should be able to take a look in the next few days - is that okay?

@oldrich-s
Copy link
Contributor Author

That's just fine 👍

@davedoesdev davedoesdev merged commit ab00d4a into davedoesdev:master May 6, 2022
@davedoesdev
Copy link
Owner

OK this is merged and the native version fixed.
Not yet published to npm - I want to update the deps etc first.

@davedoesdev
Copy link
Owner

@oldrich-s published as 7.0.0. Bumped the major version because I dropped support for Node 12.

@oldrich-s
Copy link
Contributor Author

Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants