Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heading (h1) tags not generating correctly #278

Closed
MatthewJamesHanson opened this issue Nov 17, 2021 · 5 comments
Closed

Heading (h1) tags not generating correctly #278

MatthewJamesHanson opened this issue Nov 17, 2021 · 5 comments
Labels
Waiting for release fixed, waiting for a release

Comments

@MatthewJamesHanson
Copy link

MatthewJamesHanson commented Nov 17, 2021

I'm not sure what caused this. We've been using daux without this issue. Now the < h# > tags are not being generated correctly on the site on any page anywhere.

In each case, the symptoms are like this:
image

while the markdown is like this:
image

and the html is like this;
image

Thanks for any help

-- Edit

I can put this into the markdown and it works as expected

<h2> some heading</h2>

For any one else, if you are having this problem. This is a nice solution (until the issue is fixed). This allows for the table of contents to still be created (whereas if you just use the manual <h#> tags, the table of contents is not generated with content.
image

@MatthewJamesHanson MatthewJamesHanson changed the title h1 tags not generating correctly Heading (h1) tags not generating correctly Nov 17, 2021
@onigoetz
Copy link
Contributor

onigoetz commented Dec 1, 2021

Hello, sorry for the delay.

I can't reproduce your issue just out of the box so I'd need to have a bit more information on your setup

  • what version of Daux are you using ?
  • are you using it through a Docker image or installed through Composer ?
  • if composer, is it in a project with other dependencies (like commonmark)
  • are you using any Processor ?

@MatthewJamesHanson
Copy link
Author

what version of Daux are you using ?
daux/daux.io 0.16.2

are you using it through a Docker image or installed through Composer ?
Installed through composer.

if composer, is it in a project with other dependencies (like commonmark)
Never heard of commonmark. No dependencies that I'm aware of. We just use a directory of markdown files -- so our setup is basic.

are you using any Processor ?
I didn't configure any specifically, so only any that are in use by default.

@MatthewJamesHanson
Copy link
Author

MatthewJamesHanson commented Apr 13, 2022

I resolved this manually. The underlying issue is still odd and not resolved, but for others (if any) here is what I did:
Upgraded PHP to 8.1.4, then had to resolve this bug (barryvdh/laravel-dompdf#757) manually, by changing line 79 in C:\Users\<me>\AppData\Roaming\Composer\vendor\daux\daux.io\libs\Tree\Directory.php
$buckets['numeric'][abs(($exploded[0])][$key] = $entry;
to this line
$buckets['numeric'][abs((int)$exploded[0])][$key] = $entry;

ciao!

onigoetz added a commit that referenced this issue Dec 10, 2022
@onigoetz
Copy link
Contributor

Thanks for the feedback, I added the proposed fix

@onigoetz onigoetz added the Waiting for release fixed, waiting for a release label Dec 10, 2022
@onigoetz
Copy link
Contributor

This change has been released in 0.20.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Waiting for release fixed, waiting for a release
Projects
None yet
Development

No branches or pull requests

2 participants