Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat/room-music-player #98

Merged
merged 24 commits into from
Mar 26, 2024
Merged

feat/room-music-player #98

merged 24 commits into from
Mar 26, 2024

Conversation

MAXOUXAX
Copy link
Contributor

@MAXOUXAX MAXOUXAX commented Feb 7, 2024

No description provided.

@MAXOUXAX MAXOUXAX added feature Issues that plan on adding features backend Backend related issues frontend Frontend related issues labels Feb 7, 2024
@MAXOUXAX MAXOUXAX added this to the Itération 5 milestone Feb 7, 2024
@MAXOUXAX MAXOUXAX self-assigned this Feb 7, 2024
@MAXOUXAX MAXOUXAX linked an issue Feb 7, 2024 that may be closed by this pull request
Gestion de la musique en cours de lecture #94
Closed
@MAXOUXAX MAXOUXAX changed the title refactor(ws): responses can now handle errors feat/room-music-player Feb 7, 2024
@MAXOUXAX MAXOUXAX modified the milestones: Itération 5, Itération 6 Feb 21, 2024
@MAXOUXAX
refactor(ws): responses can now handle errors
af35a3b
@MAXOUXAX
feat(ui): added loading state on button
fc15604
@MAXOUXAX
feat(frontend): now displaying loaders whenever an action is being ex…
132bfdf 
…ecuted
@MAXOUXAX
refactor(ws): started big refactor of websocket communication
595c6f3
@MAXOUXAX
refactor(ws): finished websocket refactoring by moving all local play…
fb8b9dd 
…er events to localplayer component
@MAXOUXAX
feat(ui): improved loading state inside button by rendering all conte…
5ded50c 
…nt but setting its opacity to 0
@MAXOUXAX
fix(ui): fixed button not taking multiple lines if text overflows
59e5e0c
@MAXOUXAX
style(room): improved active room layout
acc5c09
@MAXOUXAX
fix(backend): SoundCloud authentication not working, using web scrapi…
3259ef9 
…ng temporarily
@MAXOUXAX
fix(ws): fixed payload format
90ae88d
@MAXOUXAX
chore: added updated_at date
d7e4dc9
@MAXOUXAX
refactor(frontend): moved progress bar inside PlayerControls
3744a4a
@MAXOUXAX
chore: added updated_at into playback state for Spotify
47cc63d
@MAXOUXAX
fix(backend): removed useless return reply
f60eb4d
@MAXOUXAX
feat(backend): added playbackState and previousPlaybackState for room
63de905
@MAXOUXAX
refactor(backend): moved playback controller loop inside RoomStorage
2688c5a
@MAXOUXAX
feat(backend): when the queue is empty, immediately play the track wh…
e8b33d0 
…en a track is added to the queue
@MAXOUXAX
fix(backend): only start the track immediately if none is playing
a9ac92c
@MAXOUXAX
feat: improve spotify errors handling, added music logic, queue handl…
bf6c702 
…ing, and much more
@MAXOUXAX MAXOUXAX marked this pull request as ready for review March 19, 2024 16:50
@MAXOUXAX
Copy link
Contributor Author

@datsmysong/developpeurs hey, this is ready for review :)
would love it if you could do it before the end of the week

Flotss
Flotss approved these changes Mar 20, 2024
View reviewed changes
Copy link

@Flotss Flotss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, I've added comments

backend/src/musicplatform/remotes/SpotifyRemote.ts Show resolved Hide resolved
backend/src/socketio/RoomIO.ts Outdated Show resolved Hide resolved
expo/components/player/RoomPlayer.tsx Show resolved Hide resolved
expo/components/player/SoundCloudPlayer.tsx Fixed Show resolved Hide resolved
expo/components/player/SoundCloudPlayer.tsx Show resolved Hide resolved
GaspardBBY
GaspardBBY approved these changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@GaspardBBY GaspardBBY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MAXOUXAX
Copy link
Contributor Author

@ngomesodent @TheRealSharKzy @drmolixcool still awaiting your reviews guys 🤞

TheRealSharKzy
TheRealSharKzy approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@TheRealSharKzy TheRealSharKzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, didn't see anything that shocked me...

@MAXOUXAX MAXOUXAX merged commit 1b507cf into main Mar 26, 2024
5 checks passed
@MAXOUXAX MAXOUXAX deleted the feat/room-music-player branch March 26, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drmolixcool drmolixcool drmolixcool approved these changes

@Flotss Flotss Flotss approved these changes

@GaspardBBY GaspardBBY GaspardBBY approved these changes

@TheRealSharKzy TheRealSharKzy TheRealSharKzy approved these changes

@ngomesodent ngomesodent Awaiting requested review from ngomesodent

Assignees

@MAXOUXAX MAXOUXAX

Labels
backend Backend related issues feature Issues that plan on adding features frontend Frontend related issues
Projects
None yet
Milestone
Itération 6
Development

Successfully merging this pull request may close these issues.

Gestion de la musique en cours de lecture
5 participants
@MAXOUXAX @drmolixcool @Flotss @GaspardBBY @TheRealSharKzy