Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/spotify-account #32

Merged
merged 19 commits into from
Jan 14, 2024
Merged

feat/spotify-account #32

merged 19 commits into from
Jan 14, 2024

Conversation

GaspardBBY
Copy link
Contributor

Added Spotify provider with PKCE (Proof Key for Code Exchange) protocol.

@GaspardBBY GaspardBBY added the feature Issues that plan on adding features label Jan 12, 2024
@GaspardBBY GaspardBBY linked an issue Jan 12, 2024 that may be closed by this pull request
5 tasks
Copy link
Contributor

@MAXOUXAX MAXOUXAX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes are required, but overall it seems pretty good to me!

expo/lib/supabase.ts Outdated Show resolved Hide resolved
expo/lib/supabase.ts Outdated Show resolved Hide resolved
expo/lib/supabase.ts Outdated Show resolved Hide resolved
backend/src/route/AuthCallbackGET.ts Outdated Show resolved Hide resolved
backend/src/route/AuthCallbackGET.ts Outdated Show resolved Hide resolved
expo/app/(auth)/connect-with-spotify.tsx Outdated Show resolved Hide resolved
expo/app/(auth)/connect-with-spotify.tsx Outdated Show resolved Hide resolved
expo/app/(auth)/index.tsx Outdated Show resolved Hide resolved
expo/app/_layout.tsx Outdated Show resolved Hide resolved
expo/app/_layout.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@MAXOUXAX MAXOUXAX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MAXOUXAX MAXOUXAX merged commit 7b655ba into main Jan 14, 2024
2 checks passed
@MAXOUXAX MAXOUXAX deleted the feat/spotify-account branch January 14, 2024 22:25
MAXOUXAX pushed a commit that referenced this pull request Jan 15, 2024
* feat(#2): connection with Spotify

* feat(backend): creation of account if not already & generate types

* refactor: formatting auth routing

* feat: auth automatism

* chore: some typo & added share Database type with monorepo

* chore: logical to force new user to choice username

* fix: spam database to get user-profile

* chore: improve some log message & UX with error handler

* fix: auth with Spotify provider in mobile

* fix: misstake with expo Screen

* feat(backend): added route /auth/redirection

* chore: improved error response

* chore: added other method to store supabase on client

* refactor(backend): improve lisibility of auth/callback

* chore(expo): refacto Alert & added scope of Spotify provider

* chore(backend): reponse to pull request

* chore(expo): added env variable to expo project with skeleton

* refactor(expo): improve code comprehension

* chore: removed unnecessary code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Issues that plan on adding features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Création de compte à partir d'un compte Spotify
2 participants