-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat/spotify-account #32
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
MAXOUXAX
requested changes
Jan 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some changes are required, but overall it seems pretty good to me!
MAXOUXAX
approved these changes
Jan 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
MAXOUXAX
pushed a commit
that referenced
this pull request
Jan 15, 2024
* feat(#2): connection with Spotify * feat(backend): creation of account if not already & generate types * refactor: formatting auth routing * feat: auth automatism * chore: some typo & added share Database type with monorepo * chore: logical to force new user to choice username * fix: spam database to get user-profile * chore: improve some log message & UX with error handler * fix: auth with Spotify provider in mobile * fix: misstake with expo Screen * feat(backend): added route /auth/redirection * chore: improved error response * chore: added other method to store supabase on client * refactor(backend): improve lisibility of auth/callback * chore(expo): refacto Alert & added scope of Spotify provider * chore(backend): reponse to pull request * chore(expo): added env variable to expo project with skeleton * refactor(expo): improve code comprehension * chore: removed unnecessary code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Spotify provider with PKCE (Proof Key for Code Exchange) protocol.