-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat/create-room #31
Merged
Merged
feat/create-room #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and reformat code with prettier
MAXOUXAX
requested changes
Jan 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's some feedback!
…thods of room.ts instead of the service name
…ming components file with maj
MAXOUXAX
added a commit
that referenced
this pull request
Jan 15, 2024
* feat(backend): add route to create a room, and methods to add it in the database * feat(frontend) : added a part of the frontend of the creating a room page * fix(backend) : fixing CORS problem * fix(backend) : fixing code smell for parameters checking in RoomPost, and reformat code with prettier * feat(frontend) : end of the frontend before review * feat(frontend) : Adjustement on CSS and frontend in general * chore : Adding an endpoint for streaming services and using it in frontend * chore : Giving directly the streaming service id to the createRoom methods of room.ts instead of the service name * fix(frontend) : changed backend url to make them dynamic * chore: deleting assets files of spotify and souncloud logo. Also renaming components file with maj * fix: Using cookies to create supabase clients and retrieve id * chore: Adding a method to create supabase client * refactor: fixed rooms routing * chore(deps): updated package-lock.json * refactor(backend): changed endpoint of streaming services * style(ui): improved style of CustomTextInput * refactor(frontend): improved ServicesList component * chore: added .env.local.example file * chore: improved typing in RoomPOST route * chore(types): changed any to actual type --------- Co-authored-by: MAXOUXAX <24844231+MAXOUXAX@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
End of issue #5 before review