Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/create-room #31

Merged
merged 21 commits into from
Jan 15, 2024
Merged

feat/create-room #31

merged 21 commits into from
Jan 15, 2024

Conversation

TheRealSharKzy
Copy link
Contributor

End of issue #5 before review

@TheRealSharKzy TheRealSharKzy requested a review from a team January 12, 2024 07:50
@TheRealSharKzy TheRealSharKzy linked an issue Jan 12, 2024 that may be closed by this pull request
@MAXOUXAX MAXOUXAX changed the title Feat/create room feat/create-room Jan 12, 2024
Copy link
Contributor

@MAXOUXAX MAXOUXAX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's some feedback!

backend/.env.local.exemple Outdated Show resolved Hide resolved
backend/src/route/RoomPOST.ts Outdated Show resolved Hide resolved
backend/src/route/RoomPOST.ts Outdated Show resolved Hide resolved
backend/src/room.ts Outdated Show resolved Hide resolved
backend/src/room.ts Outdated Show resolved Hide resolved
expo/components/parametersList.tsx Outdated Show resolved Hide resolved
expo/components/parametersList.tsx Outdated Show resolved Hide resolved
expo/components/servicesList.tsx Outdated Show resolved Hide resolved
expo/components/servicesList.tsx Outdated Show resolved Hide resolved
expo/package.json Outdated Show resolved Hide resolved
@MAXOUXAX MAXOUXAX merged commit 492b585 into main Jan 15, 2024
3 checks passed
@MAXOUXAX MAXOUXAX deleted the feat/create-room branch January 15, 2024 10:06
MAXOUXAX added a commit that referenced this pull request Jan 15, 2024
* feat(backend): add route to create a room, and methods to add it in the database

* feat(frontend) : added a part of the frontend of the creating a room page

* fix(backend) : fixing CORS problem

* fix(backend) : fixing code smell for parameters checking in RoomPost, and reformat code with prettier

* feat(frontend) : end of the frontend before review

* feat(frontend) : Adjustement on CSS and frontend in general

* chore : Adding an endpoint for streaming services and using it in frontend

* chore : Giving directly the streaming service id to the createRoom methods of room.ts instead of the service name

* fix(frontend) : changed backend url to make them dynamic

* chore: deleting assets files of spotify and souncloud logo. Also renaming components file with maj

* fix: Using cookies to create supabase clients and retrieve id

* chore: Adding a method to create supabase client

* refactor: fixed rooms routing

* chore(deps): updated package-lock.json

* refactor(backend): changed endpoint of streaming services

* style(ui): improved style of CustomTextInput

* refactor(frontend): improved ServicesList component

* chore: added .env.local.example file

* chore: improved typing in RoomPOST route

* chore(types): changed any to actual type

---------

Co-authored-by: MAXOUXAX <24844231+MAXOUXAX@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Création d'une salle d'écoute
2 participants