-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add projectcalico crds #191
base: main
Are you sure you want to change the base?
Conversation
@sumsumbee can you please give a reference to the repo that is containing the CRDs? |
@eyarz I didn't know that this was a requirement, was this documented anywhere and I just didn't see? Anyhow I reached out to their support and will let you know once I get a reply. |
you're right, need to update the docs because this is not listed anywhere. |
@eyarz there is an archive available containing the manifests which is attached to the release notes. For example here https://docs.tigera.io/calico-enterprise/latest/release-notes/ |
I think a link the the |
@eyarz I get that, but I have no influence on the way Tigera provides the crds. I have no issue in maintaining them, as I have to do it either way locally or here. I just figured other people could use them so I do it here. |
Sorry to meddle in this discussion, but what can we do if the CRD schema definitions are not on a public git repo? Sometimes the developers of the CRD don't publish those. From what I understood we can only extract the schemas from a live k8s cluster and put them in here. edit: here is an example of RBAC manager does. They define the schema in go: https://github.com/FairwindsOps/rbac-manager/blob/master/pkg/apis/rbacmanager/v1beta1/rbacdefinition_types.go but don't publish it per se. |
@eyarz do you got any update on this? |
@andreamaruccia you're raising a good point. the problem is that I don't have any way to verify that the schemas were extracted correctly. @sumsumbee you should reach out to the tigera team and ask them if the CRDs are publicly available or not. |
@eyarz I already did that. They provide it publicly via the channel I mentioned above and they also don't want to do it another way. |
Of course Calico CRDs are public. Here they are. It's not the responsibility of the maintainer to search for these links, and PRs without links should be discarded as not verifiable, IMO. |
No description provided.