Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add projectcalico crds #191

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sumsumbee
Copy link

No description provided.

@eyarz
Copy link
Member

eyarz commented Jul 23, 2023

@sumsumbee can you please give a reference to the repo that is containing the CRDs?
we will need it for future updates of the schemas.

@sumsumbee
Copy link
Author

@eyarz I didn't know that this was a requirement, was this documented anywhere and I just didn't see? Anyhow I reached out to their support and will let you know once I get a reply.

@eyarz
Copy link
Member

eyarz commented Jul 24, 2023

you're right, need to update the docs because this is not listed anywhere.

@sumsumbee
Copy link
Author

@eyarz there is an archive available containing the manifests which is attached to the release notes.

For example here https://docs.tigera.io/calico-enterprise/latest/release-notes/

@eyarz
Copy link
Member

eyarz commented Jul 25, 2023

I think a link the the CustomResourceDefinition on github will be a better reference for future updates.

@sumsumbee
Copy link
Author

sumsumbee commented Jul 25, 2023

@eyarz I get that, but I have no influence on the way Tigera provides the crds. I have no issue in maintaining them, as I have to do it either way locally or here. I just figured other people could use them so I do it here.

@andreamaruccia
Copy link

andreamaruccia commented Aug 1, 2023

Sorry to meddle in this discussion, but what can we do if the CRD schema definitions are not on a public git repo? Sometimes the developers of the CRD don't publish those. From what I understood we can only extract the schemas from a live k8s cluster and put them in here.

edit: here is an example of RBAC manager does. They define the schema in go: https://github.com/FairwindsOps/rbac-manager/blob/master/pkg/apis/rbacmanager/v1beta1/rbacdefinition_types.go but don't publish it per se.

@sumsumbee
Copy link
Author

@eyarz do you got any update on this?

@eyarz
Copy link
Member

eyarz commented Aug 17, 2023

@andreamaruccia you're raising a good point.
this is the first time I'm addressing this issue of having schemas that are not open source.

the problem is that I don't have any way to verify that the schemas were extracted correctly.
also, the vision for this project is that one day the schema will auto-update when there is a new release and I'm wondering how it will work with "closed-source" schemas.

@sumsumbee you should reach out to the tigera team and ask them if the CRDs are publicly available or not.

@sumsumbee
Copy link
Author

@eyarz I already did that. They provide it publicly via the channel I mentioned above and they also don't want to do it another way.

@akamac
Copy link
Contributor

akamac commented Apr 12, 2024

Of course Calico CRDs are public. Here they are.
CRDs, that are not public, should land to this repo. Use your own fork then.

It's not the responsibility of the maintainer to search for these links, and PRs without links should be discarded as not verifiable, IMO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants