Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.0 #48

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

4.0 #48

wants to merge 7 commits into from

Conversation

curran
Copy link
Member

@curran curran commented Oct 13, 2018

Implements 4.0 Ideas #42

Interestingly, these changes reduce the minified build from 825 to 760 bytes.

Reviews welcome!

@curran curran changed the title V4 4.0 Oct 13, 2018
@curran
Copy link
Member Author

curran commented Oct 13, 2018

I'm having second thoughts on the naming.

Perhaps instead of

const dataflow = topologica()

we could have

const topologica = Topologica()

Pros:

  • It would be a clear signal to anyone reading the code that they are dealing with an instance of Topologica.js, which is not necessarily clear if you come across dataflow in code somewhere.
  • It's less cognitive burden.
  • It follows the object oriented convention where instances are lower case versions of their constructors.

Cons:

  • It's a rather abstract name for the instance, but at least it makes it clear what it is. Is it a state? is it a dataflow? No, it's a topologica! This feels right, as the concept is pretty unique to this library. Although, it would be interesting to research what other libraries use for this term - the instance of the reactive thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant