Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chainable set #35

Merged
merged 3 commits into from
Sep 9, 2018
Merged

Chainable set #35

merged 3 commits into from
Sep 9, 2018

Conversation

curran
Copy link
Member

@curran curran commented Sep 9, 2018

Closes #33

This implementation returns this. It's simpler than the original implementation in #34, results in a slightly smaller bundle, and covers the desired use case.

Before:

const state = Topologica({ circlesDOM });
state.set({ selection });
return state;

After:

return Topologica({ circlesDOM }).set({ selection });

Full example: https://vizhub.com/curran/27c261085d8a48618c69f7983672903b

@curran curran mentioned this pull request Sep 9, 2018
@curran curran changed the title Chainable set alternate implementation Chainable set Sep 9, 2018
@curran curran merged commit 19940a9 into master Sep 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant