[Bug-358][api] Delete Cluster #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
新增集群状态[停止],当服务全停止时集群会改为停止状态, 此时可以删除集群
新增集群状态[删除中][已删除],当删除集群时会切换为[删除中],并发送命令将数据文件夹重命名,最后移除集群主机并置[已删除]
新增集群状态[删除中][已删除],当删除集群时会切换为[删除中],并发送命令将数据文件夹重命名,最后移除集群主机并置[已删除]
datasophon
reviewed
Aug 9, 2023
datasophon-dao/src/main/java/com/datasophon/dao/enums/ClusterState.java
Outdated
Show resolved
Hide resolved
datasophon-common/src/main/java/com/datasophon/common/enums/ClusterCommandType.java
Outdated
Show resolved
Hide resolved
datasophon
reviewed
Aug 9, 2023
| ClusterServiceRoleGroupConfig config = clusterServiceRoleGroupConfigService.getConfigByRoleGroupId(roleInstance.getRoleGroupId()); | ||
| List<ServiceConfig> oldConfigs = ProcessUtils.getServiceConfig(config); | ||
| Map<Generators, List<ServiceConfig>> configFileMap = new ConcurrentHashMap<>(); | ||
| ProcessUtils.generateConfigFileMap(configFileMap, config); |
There was a problem hiding this comment.
为了留底,
因为删除集群只是将状态变更为[已删除],并不会物理删除记录, 因此删除后依然可以在服务配置里查看到备份后的目录
There was a problem hiding this comment.
删除集群会删除所有服务以及服务的配置，更改配置是否有必要？
rename
修改为删除所有服务及集群
code clean
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
fix #358
Brief change log
新增集群状态[停止][删除中][已删除]
当服务全停止时集群会改为停止状态, 此时可以删除集群
当删除集群时会切换为[删除中],并发送命令将数据文件夹重命名,最后移除集群主机并置[已删除]
Verify this pull request
This pull request is code cleanup without any test coverage.