Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed an issue with HMI not getting fetched correctly #447

Merged
merged 3 commits into from
Sep 23, 2021
Merged

Fixed an issue with HMI not getting fetched correctly #447

merged 3 commits into from
Sep 23, 2021

Conversation

leymytel
Copy link
Contributor

@leymytel leymytel commented Sep 21, 2021 •
edited
Loading

Description

This PR includes:

  • Fix to the HMI endpoint.
  • Moved PDA Details into redux.
  • Deleted old "user/login" and "user/recover/password" paths (deprecated)

Type

  • Bug Fix
  • Feature Addition
  • Refactor
  • HotFix

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

@leymytel leymytel requested a review from Ddeak September 21, 2021 13:25
@Ddeak
Copy link
Contributor

Ddeak commented Sep 21, 2021

LGTM

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
19.6% 19.6% Duplication

@leymytel leymytel merged commit 7a9600f into domain-change Sep 23, 2021
@leymytel leymytel deleted the leymytel/bug-fix branch September 23, 2021 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ddeak Ddeak Ddeak approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leymytel @Ddeak