Fix SNI events #513
Merged
Fix SNI events #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The address in status/topology events needs to be mapped to internal SNI address so that nodes will be properly added and removed.
zakalibit
reviewed
Oct 16, 2021
|
Just as an additional input, this branch works for us when using AWS Keyspace while we have intermittent issues with the current release. I hope this gets accepted soon. |
fsaporito
pushed a commit
to cloudian/cpp-driver
that referenced
this pull request
May 9, 2023
* Fix events when using SNI routing The address in status/topology events needs to be mapped to internal SNI address so that nodes will be properly added and removed. * Additional fixes * Formatting fix * Simplify logic Co-authored-by: Bret McGuire <bret.mcguire@datastax.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using SNI routing the driver is not mapping event address to the representation used by the driver (an
Addresswith an IP and SNI name). It needs to be mapped using therpc_addressfrom the system tables.