Customer uk merge test #643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Initial commit * Added maximum length in the complex input type. --------- Co-authored-by: MilanMajchrák <milan.majchak@dataquest.sk>
…larin-search` * Initial commit * Added maximum length in the complex input type. * Added `clarin-search` component to the search-page --------- Co-authored-by: MilanMajchrák <milan.majchak@dataquest.sk>
Co-authored-by: MilanMajchrák <milan.majchak@dataquest.sk>
…info * Fixed loading the license into selection and fixed assigning wrong license after choosing it. * Fixed sending an email with download link - added email input field. * Removed console log messages. --------- Co-authored-by: MilanMajchrák <milan.majchak@dataquest.sk>
* Trying to compose required information to the item page. * Raw version of the updated item-page. * Fixed ref-box when the item has more authors. * Removed unused files. * Removed logging to the console. * Export new component from the item-page.module * Refactoring - beautify the code * Removed disabled components from the item-page.module * Removed unuseful tests. --------- Co-authored-by: MilanMajchrák <milan.majchak@dataquest.sk>
… changed * Fixed search pagination. * Updated object-list was used by more components. Use CLARIN changes only in the search-page. It is separated by the config.id. --------- Co-authored-by: MilanMajchrák <milan.majchak@dataquest.sk>
Co-authored-by: MilanMajchrák <milan.majchak@dataquest.sk>
* Show ClarinItemBoxView only in searching, not in the /mydspace page * Updated tombstoned items based on the updated database model. * Updated loading of the dump for the integration tests. * Commented out failing test. * Changed test dump --------- Co-authored-by: MilanMajchrák <milan.majchak@dataquest.sk>
* Added validation for the complex input field * Commented out failing test. * Changed test dump --------- Co-authored-by: MilanMajchrák <milan.majchak@dataquest.sk>
* Created clarin-name input field * Suggestions for the author name are showed up * Show author input field which consist of autocomplete and input * Lastname autocomplete add a value into both input fields. * Fixed some graphic and easy issues, failing tests and refactoring * The input fields value wasn't filled in after selecting the option. * Uncomment commented integration tests * Little refactoring and added docs * Changed test dump * Changed IT expected values, just trying. * Changed IT just check it there is two input fields. --------- Co-authored-by: MilanMajchrák <milan.majchak@dataquest.sk>
* Trying to create own component for selecting the Clarin License. * The dropdown select is scrollable. * Added default option. * Added searching for the license selector. * Maybe finally I've done that lovely license selector. * Fixed lint error after solving the conflicts. * Refactoring and added docs. * Beautified license selector. --------- Co-authored-by: MilanMajchrák <milan.majchak@dataquest.sk>
* Added a new empty notice step. * Set up Notice Step body. * Created a test for the new step * Beautify code * Added integration tests for the Notice Step * Changed dump for test environment. --------- Co-authored-by: MilanMajchrák <milan.majchak@dataquest.sk>
* Fixed pagination and added a new search input field for better overview in the licenses. * Fixed tests * Fixed integration tests. --------- Co-authored-by: MilanMajchrák <milan.majchak@dataquest.sk>
* Make discojuice active on login button * When the user click on the `Local authentication` - redirect him to `/login` page. --------- Co-authored-by: MilanMajchrák <milan.majchak@dataquest.sk>
* After clicking on the author the user is redirected into search page with current author. * Some fields are fixed * Added subject and some fields are fixed. * Added author metadata field, the clarin-author-preview component was created and added into clarin-item-box-view.component * Acknowledgement was overlaying the metadata value - fixed * Refacroting and added docs. * Refactored if --------- Co-authored-by: MilanMajchrák <milan.majchak@dataquest.sk>
repoPath already contains hostname and port. use authn/shibboleth instead of shibboleth-login
* Removed redirecting in the FE - redirecting is made in the BE. * Commented failing test. * Added todo into commented test.
* Updated ClarinItemViewBox * Fixed NewHandleComponent tess * Removed unused imports
* The user is redirected to the license agreement page * ClarinAuthorization request must be completed
* Initial commit * The user metadata value couldn't be seen. * Updated unit test according to new changes.
Co-authored-by: Ondřej Košarko <ko_ok@centrum.cz>
* Updated license definition form messages for required info labels. * The confirmation default value is loaded.
[devOps] show healthcheck in a separate step
add forgotten var
* Show error message from the error response (cherry picked from commit e6546b4) * fix(i18n): add and update missing status strings New strings for status filter entries: search.filters.namedresourcetype.* Refactored strings introduced with DSpace#2068 (refactor badged), e.g. mydspace.status.archived -> mydspace.status.mydspaceArchived * 104126: ProcessDetailComponent test improvement * Bump word-wrap from 1.2.3 to 1.2.5 Bumps [word-wrap](https://github.com/jonschlinkert/word-wrap) from 1.2.3 to 1.2.5. - [Release notes](https://github.com/jonschlinkert/word-wrap/releases) - [Commits](jonschlinkert/word-wrap@1.2.3...1.2.5) --- updated-dependencies: - dependency-name: word-wrap dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> (cherry picked from commit 2fec33e) * Replace mentions of demo7.dspace.org and api7.dspace.org with demo or sandbox * Update default configs to use https://demo.dspace.org/server/ * 2437 Correct and clarify commented-out code in several custom components - Correct the path in commented-out code in the custom theme's components - Clarify that the workflow-item-sen-back.component.scss file is a stub - It has no corresponding SCSS file in the base theme (cherry picked from commit 0906234) * fix lint error in workflow-item-send-back.component.ts (cherry picked from commit 518cc71) * Enable new skip merge commit feature * 103818 Add warning tooltip to "Inherit policies" checkbox on item move page * 103818 Adjusted "Inherit policies" tooltip * Update pl.json5 Update from 7.4 to 7.6 version (cherry picked from commit b439ab4) * Update pl.json5 Translation update of 2 spaces instead of 3 (cherry picked from commit cfd753f) * Update pl.json5 fix issues from tests (cherry picked from commit 93299ec) * Update pl.json5 fix test 2 spaces instead of 1 (cherry picked from commit f58a7a2) * 105265: Made the DsDynamicListComponent's checkbox & radio buttons ids unique for each metadata field to prevent other value-pairs having the same id (cherry picked from commit 4c419e1) * Fix lint issue. * 103176: Fix vcr not being defined yet in OnInit hook * 101577: Ensure the component is always destroyed before rendering the new component * Reset to base theme when no default theme is set and leaving UUID/handle theme * Merge branch 'fix-ngonchanges-not-working-for-themed-components_contribute-7.2' into fix-ngonchanges-not-working-for-themed-components_contribute-7.4 * 🐛 go to first page after submit search (cherry picked from commit 88a7088) * ✅ add first page condition when search submit (cherry picked from commit 0442302) * Replace h5 with a span (cherry picked from commit 5ef4a82) * Replace h2 with a h1 (cherry picked from commit 05c53ad) * Add trackby function so cdktree can differentiate between new and old nodes (cherry picked from commit 5f71de8) * Improve documentation (cherry picked from commit d9b6e9d) * Reorder instance method to come after member declaration (cherry picked from commit e59913a) * fix(i18m): curation-task.task.registerdoi.label changed curation-task.task.register-doi.label back to curation-task.task.registerdoi.label and added German translation (cherry picked from commit 0ec72f6) * Implemented i18n cache busting * Update to latest cypress (cherry picked from commit 68a3323) * Update to latest axe-core (cherry picked from commit 50899f1) * Reenable accessibility check fixed in DSpace#2251 (cherry picked from commit 158ebb0) * Enable excessibility checking of login menu, and remove unnecessary exclusion from header (cherry picked from commit 339ed63) * Fix heading order issue with item page & update accessibility tests to prove it now passes (cherry picked from commit ba244bf) * Update ng2-nouislider and nouislider to latest versions (cherry picked from commit 91d8b7e) * Fix accessibility of date sliders by adding aria-labels (cherry picked from commit 2a88179) * Minor fixes to cypress tests (cherry picked from commit 70a7bbe) * Fix heading order accessibility issue in search filters/facets (cherry picked from commit 276d808) * Spanish translation updated to 7.6 (cherry picked from commit 4cc4192) * Some lint errors fixed (cherry picked from commit 1885638) * 🐛 fix when navbar expands on firefox (cherry picked from commit 6070672) * 🐛 Fix Value of dropdown changes automatically on item submission page (cherry picked from commit 6513059) * ✅change test event, click by mousedown on dynamic-scrollable-dropdown.component.spec.ts (cherry picked from commit 25479e1) * config/config.example.yml: fix example syntax As of DSpace Angular 7.2 the syntax has changed from TypeScript to YAML. (cherry picked from commit 9e46b53) * Fix VocabularyTreeview not updating + i18n for nsi (cherry picked from commit b5a70e8) * 104189: Allow CSV export on related entity search (cherry picked from commit cac1407) * 104189: CSV export add fixedFilter (cherry picked from commit 45ad5f7) * Minor pt-PT translation fixes (cherry picked from commit a6c1120) * remove redundant cache default values from server.ts (cherry picked from commit e53abcb) * 🚸remove thumbnail from file-upload section and show bitstream format and checksum (cherry picked from commit 4c8ec8a) * 🎨revert unnecessary format (cherry picked from commit 13e4052) * Update workspaceitem-section-upload-file.model.ts Fix code comment (cherry picked from commit 01c8a4d) * ♻️ refactor chain of observables to avoid async issues (cherry picked from commit 2dc9fd4) * 🐛 fix bug of caching when add new schema (cherry picked from commit 9fb9e58) * 🎨 revert format (cherry picked from commit 3e5524d) * Fix innerText still being undefined in ssr mode * Correct text of help info on edit group page (cherry picked from commit 4924743) * Graceful shutdown on SIGINT (e.g. from 'pm2 stop'). (cherry picked from commit 6709c3b) * Properly await termination. (cherry picked from commit 4449737) * Document a modified method as required by PR guidelines. (cherry picked from commit bf9b2b8) * 106974: Angular SSR menu issues * src/app/shared/search: don't capitalize metadata values Don't capitalize metadata values for display purposes. * fix issue where more than one api call was made on every route change * fix issue where invalidateRootCache didn't happen when the page first loaded * remove obsolete label element in metadata-schema.component.html (cherry picked from commit 6847c30) * removed trailing whitespaces as suggested by reviewer (cherry picked from commit 43f19e7) * [Port dspace-7_x] Update fi.json5 (DSpace#2516) * Update fi.json5 Two last translations to the Finnish file. (cherry picked from commit c3a908b) * Fix routes not working with baseHref (cherry picked from commit 18febff) * [Port dspace-7_x] Serbian (Latin) translation (DSpace#2520) * Serbian (latin) translation added. --------- Co-authored-by: imilos <imilos@gmail.com> * [Port dspace-7_x] Fix missing or wrong Italian translations (DSpace#2522) [DURACOM-184] fix missing or wrong Italian translations --------- Co-authored-by: Andrea Barbasso <´andrea.barbasso@4science.com´> * fix dev mode issue where retrieving the login options fails * roll back unintended change to the responseMsToLive for RootDataservice * [DURACOM-185] Fix pointer on language dropdown menu (cherry picked from commit 6b5708c) * Move subscription button to DSO edit menu (cherry picked from commit c955816) * Update DSO edit menu resolver tests - Abstract away the different "subsections" ~ DSO type (the tests should not care about this) Instead, retrieve sections of interest by ID & assert whether they're there & how they should look - Test separately for Communities, Collections & Items - Test newly added menu section (cherry picked from commit 18b7a9c) * Issue#2535: Hide add more button in submission if no disabled sections * translate community as 'Bereich' in de.json5 (cherry picked from commit 0139670) * Fix browse by visual bug (cherry picked from commit d0b4e15) * Bump postcss from 8.4.23 to 8.4.31 Bumps [postcss](https://github.com/postcss/postcss) from 8.4.23 to 8.4.31. - [Release notes](https://github.com/postcss/postcss/releases) - [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md) - [Commits](postcss/postcss@8.4.23...8.4.31) --- updated-dependencies: - dependency-name: postcss dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> (cherry picked from commit 3c5079e) * check cssRules existence before css variables are get from stylesheet (cherry picked from commit 367cda2) * checkstyle remove unused extra lines (cherry picked from commit 5f8a9de) * 107664: Normalized ePerson & group edit url and moved error message to translation file * Bump @babel/traverse from 7.21.4 to 7.23.2 Bumps [@babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse) from 7.21.4 to 7.23.2. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.23.2/packages/babel-traverse) --- updated-dependencies: - dependency-name: "@babel/traverse" dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> (cherry picked from commit 97f7a5e) * Revert "Check cssRules before css variables are read from stylesheet (DSpace#2454)" This reverts commit fa79c35. (cherry picked from commit 6f73b65) * Update email-request-copy.component.html Message is optional: remove req in [disabled] (cherry picked from commit 94c756d) * Fix RequestService test failing because of different lastUpdated time (cherry picked from commit fb31533) * Use gap instead of individual paddings for header icons (cherry picked from commit 9f2a1d0) * Themed LangSwitchComponent (cherry picked from commit f9b4460) * Applied same gap between header icons in the dspace theme and made the search field non-focusable when collapsed (cherry picked from commit 58d31dd) * Fixed invalid html structure the ExpandableNavbarSectionComponent had an ul tag containing non-li tags (cherry picked from commit fa56d5d) * Added Serbian cyrilic translation and corrected Serbian latin translation. (cherry picked from commit ad12e5a) * Added Serbian cyrilic translation and corrected Serbian latin translation. (cherry picked from commit aa9e12d) * Merge branch 'fix-display-order-authentication-methods_contribute-7.4' into fix-display-order-authentication-methods_contribute-7.6 * Added themed-user-menu component. * Corrected missing semicolon. * Replaced tags for ds-user-menu. * Included user-menu component in custom theme. * Removed default value from inExpandableNavbar. * [DURACOM-190] Fix i18n labels in vocabulary-treeview (cherry picked from commit b321d6f) * [DURACOM-190] Fix alignment in vocabulary-treeview (cherry picked from commit feb2b2b) * allow to insert multi-line scope notes in MD field registry (cherry picked from commit 5bc5dd8) * Added support for changing the color of the navbar (cherry picked from commit f6649e1) * Fixed header bg color not being set in default (no) theme (cherry picked from commit 14b1ce5) * Fixed breadcrumb padding using incorrect syntax (cherry picked from commit 6c48238) * Added new variables for the expandable navbar section (cherry picked from commit 2ca2a38) * New themed components & minor CSS fixes (DSpace#2442) * 100839: Created themeable BrowseByComponent * 100839: Added themed BrowseByComponent to custom theme * 100839: Added themed BrowseEntryListElementComponent to custom theme * Added PersonComponent to custom theme * Themed LogInComponent * Fix focus on navbar using different color * Fix ccLicense checkbox margin * Fix long search facets name not displaying correctly * Removed RecentItemListComponent's unnecessary float causing alignment issues when adding components underneath it * Themed RegisterEmailFormComponent * more error-prone check of cssRules existence before css variables are get from stylesheet check the existence off cssRules property before the variables are readed from this stylesheet DSpace#2450 (cherry picked from commit 4dd334f) * fix(pt-BR.json5): fix and update the language file Fix and update the pt-BR language file * fix(pt-BR.json5): fix and update the language file and previous errors Fix and update the pt-BR language file and the previous errors * Merged in DSC-106 (pull request #643) [DSC-106] Date input usable via keyboard using tab Approved-by: Vincenzo Mecca (cherry picked from commit 543b4ad) * [DURACOM-194] fixed year input value on input type date (cherry picked from commit c412c1f) * Ensure e2e tests run in production mode (cherry picked from commit 7dcaae8) * Specify user agent to avoid being detected as a "bot" by backend (cherry picked from commit 72cda41) * [DURACOM-177] gap-* classes (cherry picked from commit 930a381) * [DURACOM-177] Use gap-* classes on navbar buttons (cherry picked from commit a356295) * [DURACOM-197] Fix cache issue when depositing a submission (cherry picked from commit f992ff6) * Add UI nameSpace context path to Mirador viewer path (cherry picked from commit 3228c45) * 108055: fix issue 8686: unable to enter freetext values in the submission form for vocabulary (cherry picked from commit 0dcf6cb) * 108055: add user input to tag list (cherry picked from commit aac58e6) * Support type-bind of elements based on repeatable list type-bound element (CHECKBOX_GROUP) (cherry picked from commit 09aaa46) * [DURACOM-195] Simplify vertical spacing in header and breadcrumbs (cherry picked from commit a3e6d9b) * [DURACOM-180] Prevent header from covering media viewer controls (dspace theme) (cherry picked from commit 0208a78) * [DURACOM-180] Prevent header from covering media viewer controls (base theme) (cherry picked from commit c042cd8) * Update condition to render show more node `loadingNode` ends up being the current `node` after clicking it preventing it from rendering when more pages available. Update community list component spec Make the show more flat node id unique The nodes with same id are conflicting when added to the tree. Clicking on the second with same id places the show more button under the wrong branch and expands the wrong page. (cherry picked from commit 11d3771) * Filter expanded nodes by id Co-Authored-By: Art Lowel <1567693+artlowel@users.noreply.github.com> (cherry picked from commit dc2ef98) * Added skip to main content button * Limit getMembers() and getSubgroups() to only fetching one object. These lists are only used to find the size of each (cherry picked from commit 0da7c15) * Remove isSubgroupOfGroup() functionality as it loads every subgroup at once. Bad peformance for large groups (cherry picked from commit 97479a2) * Fix bug where linked Community/Collection info was sometimes listed many times in a row (cherry picked from commit 2292366) * Remove "isMemberOfGroup()" from members-list component. (cherry picked from commit 43d3719) * Remove unnecessary EpersonDtoModel. Rework code and tests to use EPerson instead. (cherry picked from commit bffae54) * Also remove unnecessary EpersonDtoModel from extending ReviewersListComponent. Remove "memberOfGroup" from EpersonDtoModel as it is no longer used (cherry picked from commit b598f1b) * Fix subgroups-list specs so they align with new members-list specs (cherry picked from commit 64f968b) * Refactor members-list and subgroups-list components to use new isNotMemberOf endpoints (via services) (cherry picked from commit 8a10888) * Refactor subgroups-list component's "search()" to act same as member-list component's "search()". Avoids reloading the page as frequently. (cherry picked from commit 2eb1a17) * Remove seemingly unnecessary page reload after new search. (cherry picked from commit d163db1) * Address feedback. Run empty search on init. Reorder sections to list current members before add members (for both eperson and groups) (cherry picked from commit 9117ac0) * Bump axios from 0.27.2 to 1.6.0 Bumps [axios](https://github.com/axios/axios) from 0.27.2 to 1.6.0. - [Release notes](https://github.com/axios/axios/releases) - [Changelog](https://github.com/axios/axios/blob/v1.x/CHANGELOG.md) - [Commits](axios/axios@v0.27.2...v1.6.0) --- updated-dependencies: - dependency-name: axios dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> (cherry picked from commit ef9f31d) * 108045: Fix for repeatable date field labels * Fixed test * Fix handle redirect not working with custom nameSpace (cherry picked from commit b894dce) * adding new access-status-list-element-badge css classes (cherry picked from commit e847e4e) * Create new access-status-badge.component.scss (cherry picked from commit 3bf2eb1) * new accessStatusClass atribute (cherry picked from commit 6378dbe) * remove replaceAll and use an object property (cherry picked from commit c7eae92) * adding ngOnDestroy for dealing with unsubscribe (cherry picked from commit 75b788d) * 107671: Fix handle theme not working with canonical prefix https://hdl.handle.net/ (cherry picked from commit a7faf7d) * 107671: Split Theme model & ThemeConfig classes in separate files to prevent circular dependencies (cherry picked from commit da8880e) * 107671: Fixed bug where config property would still sometimes be undefined whey calling the ngOnDestroy in the ThemedComponent (cherry picked from commit 4e54cca) * 107671: Fixed theme matching by handle not working in production mode (cherry picked from commit 7529ed8) * [DURACOM-202] feature: item edit pages are accessible by administrator (cherry picked from commit ccf1cc4) * [DURACOM-202] refactor: code (cherry picked from commit b6d515f) * [DURACOM-202] refactor: code (cherry picked from commit 6f64db1) * fix: random order of buttons in status tab (cherry picked from commit 35f8b55) * refactor: code (cherry picked from commit fbbbc18) * 107685: menu-component re-render section on store update * 107902: Created test case for 2f26e68 * Update version tag for release * empty commit - force checks * remove double permissions * Removed duplicated attributes * Use our docker workflow and docker compose * Removed empty row --------- Co-authored-by: milanmajchrak <milan.majchrak@dataquest.sk> Co-authored-by: Alan Orth <alan.orth@gmail.com> Co-authored-by: Mirko Scherf <mscherf@uni-mainz.de> Co-authored-by: Tim Donohue <tim.donohue@lyrasis.org> Co-authored-by: Kristof De Langhe <kristof.delanghe@atmire.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Hardy Pottinger <hardy.pottinger@gmail.com> Co-authored-by: Koen Pauwels <koen.pauwels@atmire.com> Co-authored-by: Michał Dykas <96572102+michdyk@users.noreply.github.com> Co-authored-by: Alexandre Vryghem <alexandre@atmire.com> Co-authored-by: Hugo Dominguez <hugo@escire.lat> Co-authored-by: Hrafn Malmquist <hrafn.malmquist@gmail.com> Co-authored-by: Sergio Fernández Celorio <sfernandez@arvo.es> Co-authored-by: Nona Luypaert <nona.luypaert@atmire.com> Co-authored-by: José Carvalho <jnsc@ua.pt> Co-authored-by: Sascha Szott <szott@gmx.de> Co-authored-by: Mark H. Wood <mwood@iu.edu> Co-authored-by: Yana De Pauw <yana@atmire.com> Co-authored-by: Art Lowel <art.lowel@gmail.com> Co-authored-by: DSpace Bot <68393067+dspace-bot@users.noreply.github.com> Co-authored-by: imilos <imilos@gmail.com> Co-authored-by: Andrea Barbasso <´andrea.barbasso@4science.com´> Co-authored-by: Davide Negretti <davide.negretti@4science.com> Co-authored-by: Yury Bondarenko <ybnd@tuta.io> Co-authored-by: Marie Verdonck <maria.verdonck@atmire.com> Co-authored-by: Janne Jensen <micrograph@posteo.de> Co-authored-by: Pascal-Nicolas Becker <pnbecker@users.noreply.github.com> Co-authored-by: Jens Vannerum <jens.vannerum@atmire.com> Co-authored-by: Gantner, Florian Klaus <florian.gantner@uni-bamberg.de> Co-authored-by: Agustina Martinez <am857@cam.ac.uk> Co-authored-by: Eike Martin Löhden <eike.loehden@ub.uni-marburg.de> Co-authored-by: Marco Aurelio Cardoso <marcoaurelio.cardoso@gmail.com> Co-authored-by: Alisa Ismailati <alisa.ismailati@atis.al> Co-authored-by: Alisa Ismailati <alisa.ismailati@4science.com> Co-authored-by: Giuseppe Digilio <giuseppe.digilio@4science.com> Co-authored-by: William Welling <wwelling@tamu.edu> Co-authored-by: Andreas Mahnke <andreas.mahnke@leuphana.de> Co-authored-by: lotte <lotte_hofstede@hotmail.com> Co-authored-by: Paulo Graça <paulo1978@gmail.com> Co-authored-by: Vlad Nouski <uladzislau.nouski@4science.com>
forgotten slash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem description