Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add state_at_close #18

Merged
merged 3 commits into from
Oct 29, 2018
Merged

Add state_at_close #18

merged 3 commits into from
Oct 29, 2018

Conversation

reginafcompton
Copy link

@reginafcompton reginafcompton commented Oct 24, 2018

This PR adds a new field to the Session model (state_at_close), which will allow us to keep track of the state a user was in, when closing a session.

@reginafcompton reginafcompton changed the title Persist state [WIP] Persist state Oct 24, 2018
@reginafcompton reginafcompton changed the title [WIP] Persist state Persist state Oct 26, 2018
@reginafcompton reginafcompton requested a review from fgregg October 26, 2018 18:20
@reginafcompton reginafcompton changed the title Persist state Add state_at_close Oct 26, 2018
@fgregg
Copy link

fgregg commented Oct 26, 2018

Is this for analytics purpose, or resuming a session?

@reginafcompton
Copy link
Author

For analytics

@reginafcompton reginafcompton merged commit c677559 into master Oct 29, 2018
@reginafcompton reginafcompton deleted the persist-state branch December 28, 2018 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants