Repeat combinator #32
Merged
+185
−140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… few core combinators like repeat, etc.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a skim through the examples we've got listed in the README, and noticed that the DateTime example had an implementation of
Repeat, which really belongs in the core library.The example was a little cluttered with the inclusion of optional
"double quotes as well as supporting time-onlyDateTimes,, so I've removed those features and hopefully boiled it down to a few core combinators. It's not an optimal implementation, since it should be possible to parse ISO-8601 without allocating, but as an introduction to Superpower it's useful.