Clean up the feature flags (#1900)

datalens-tech · Dec 9, 2024 · 9d5e656 · 9d5e656
1 parent bcc0e0b
commit 9d5e656
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 37 deletions.
diff --git a/src/server/components/features/features-list/ChartWithFnLogging.ts b/src/server/components/features/features-list/ChartWithFnLogging.ts
diff --git a/src/server/modes/charts/init-charts-engine.ts b/src/server/modes/charts/init-charts-engine.ts
@@ -3,12 +3,7 @@ import type {AppConfig, AppContext} from '@gravity-ui/nodekit';
 import get from 'lodash/get';
 import sizeof from 'object-sizeof';
 
-import {
-    AppEnvironment,
-    Feature,
-    isEnabledServerFeature,
-    isObjectWithFunction,
-} from '../../../shared';
+import {AppEnvironment} from '../../../shared';
 import CacheClient from '../../components/cache-client';
 import {ChartsEngine} from '../../components/charts-engine';
 import {getDefaultRunners} from '../../components/charts-engine/runners';
@@ -30,7 +25,6 @@ export function initChartsEngine({
     afterAuth: AppMiddleware[];
 }) {
     const getTime = () => new Date().toISOString().replace('T', ' ').split('.')[0];
-    const shouldLogChartWithFunction = isEnabledServerFeature(ctx, Feature.ChartWithFnLogging);
 
     const telemetryCallbacks: TelemetryCallbacks = {
         onConfigFetched: ({id, statusCode, requestId, latency = 0, traceId, tenantId, userId}) => {
@@ -116,23 +110,10 @@ export function initChartsEngine({
         },
 
         onTabsExecuted: ({result, entryId}) => {
-            const {
-                config: chartConfig,
-                highchartsConfig,
-                sources,
-                sourceData,
-                processedData,
-            } = result;
+            const {sources, sourceData, processedData} = result;
             const chartEntryId = entryId || '';
             const datetime = Date.now();
 
-            if (
-                shouldLogChartWithFunction &&
-                (isObjectWithFunction(chartConfig) || isObjectWithFunction(highchartsConfig))
-            ) {
-                ctx.stats('chartsWithFn', {datetime, entryId: chartEntryId});
-            }
-
             let rowsCount = 0;
             let columnsCount = 0;
             if (sourceData && typeof sourceData === 'object') {

diff --git a/src/shared/modules/charts-shared.ts b/src/shared/modules/charts-shared.ts
@@ -1,6 +1,5 @@
 import {dateTime, dateTimeParse} from '@gravity-ui/date-utils';
 import type {DurationUnit} from '@gravity-ui/date-utils';
-import isFunction from 'lodash/isFunction';
 
 import type {ServerDatasetField} from '../types';
 
@@ -349,7 +348,3 @@ export function isObjectWith(
 
     return false;
 }
-
-export function isObjectWithFunction(value: unknown) {
-    return isObjectWith(value, isFunction, []);
-}
diff --git a/src/shared/types/feature.ts b/src/shared/types/feature.ts
@@ -19,6 +19,7 @@ export enum Feature {
     FetchDocumentation = 'FetchDocumentation',
     Comments = 'Comments',
     EmptySelector = 'emptySelector',
+    // Check access rights when processing ChartEditor charts
     ChartEditorDeveloperModeCheck = 'ChartEditorDeveloperModeCheck',
     QLPrometheus = 'QLPrometheus',
     QLMonitoring = 'QLMonitoring',
@@ -28,13 +29,17 @@ export enum Feature {
     DashBoardSupportDescription = 'DashBoardSupportDescription',
     DashAutorefresh = 'DashAutorefresh',
     GSheetsV2Enabled = 'GSheetsV2Enabled',
+    // Show request body in the Inspector dialog
     ShowInspectorDetails = 'ShowInspectorDetails',
+    // Prohibiting the serialization of functions in the chart configs
     NoJsonFn = 'NoJsonFn',
     GSheetGoogleAuthEnabled = 'GSheetGoogleAuthEnabled',
     DatasetsRLS = 'DatasetsRLS',
+    // The ability to upload xlsx files for file connections
     XlsxFilesEnabled = 'XlsxFilesEnabled',
     XlsxChartExportEnabled = 'XlsxChartExportEnabled',
     GroupControls = 'GroupControls',
+    // Escaping field values in chart tooltips (only scatter, treemap, geopoints visualizations)
     EscapeUserHtmlInDefaultHcTooltip = 'EscapeUserHtmlInDefaultHcTooltip',
     HolidaysOnChart = 'HolidaysOnChart',
     ReadOnlyMode = 'ReadOnlyMode',
@@ -59,7 +64,6 @@ export enum Feature {
     MultipleColorsInVisualization = 'MultipleColorsInVisualization',
     ConnectionBasedControl = 'ConnectionBasedControl',
     EnableServerlessEditor = 'EnableServerlessEditor',
-    ChartWithFnLogging = 'ChartWithFnLogging',
     EnableFooter = 'EnableFooter',
     MassRemoveCollectionsWorkbooks = 'MassRemoveCollectionsWorkbooks',
     /* Enable dashboard fixed header */