Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebook Readonly #313

Merged
merged 14 commits into from
Sep 13, 2024
Merged

Notebook Readonly #313

merged 14 commits into from
Sep 13, 2024

Conversation

echarles
Copy link
Member

On top of the viewer, the Notebook has now a readonly prop.

This PR also

  • Add index.ts in folders
  • Favor JupyterReactTheme in the example
  • Centralize the theme related code.

@echarles echarles added the feature New feature or request label Sep 13, 2024
@@ -73,18 +73,18 @@
if (module.default) {
document.body.insertAdjacentHTML(
'afterbegin',
`<style ${DATASET_LAB_THEME}="${colorMode}">
`<style ${DATASET_LAB_THEME}="${colormode}">

Check warning

Code scanning / CodeQL

Unsafe HTML constructed from library input Medium

This HTML construction which depends on
library input
might later allow
cross-site scripting
.
This HTML construction which depends on
library input
might later allow
cross-site scripting
.
This HTML construction which depends on
library input
might later allow
cross-site scripting
.
@echarles echarles merged commit 7ca1011 into main Sep 13, 2024
3 of 4 checks passed
@echarles echarles deleted the notebook/readonly branch September 13, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants