Handling uncaught runtime error in promise when executing code in output #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…model notifications only when all code execution completed
… occurs in Output
echarles
approved these changes
Sep 9, 2024
echarles
pushed a commit
that referenced
this pull request
Sep 9, 2024
…put (#302) * Added notifyOnComplete paramater for code execution enabling to send model notifications only when all code execution completed * Fixed missing metadata parameter for OutputExecutor * Fixed JSONObject initialization * Fixed uncaught runtime exception in promise when code execution error occurs in Output --------- Co-authored-by: Sergey Kadnikov <skadnikov@seeneco.ru>
echarles
added a commit
that referenced
this pull request
Sep 9, 2024
* docs: context and state * Handling uncaught runtime error in promise when executing code in output (#302) * Added notifyOnComplete paramater for code execution enabling to send model notifications only when all code execution completed * Fixed missing metadata parameter for OutputExecutor * Fixed JSONObject initialization * Fixed uncaught runtime exception in promise when code execution error occurs in Output --------- Co-authored-by: Sergey Kadnikov <skadnikov@seeneco.ru> * bump: version --------- Co-authored-by: Sok82 Developer <developer.d20@gmail.com> Co-authored-by: Sergey Kadnikov <skadnikov@seeneco.ru>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #301