fix: perform proper provision in an annex remote #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes an issue where subdataset provision did not work if `provision` was invoked from an annex special remote-process. The reason for the error was that the special remote sets the environment variables `GIT_DIR` and `GIT_WORK_TREE`, which lead to problems in `datalad.get`.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #79 +/- ##
=======================================
Coverage 91.55% 91.55%
=======================================
Files 24 25 +1
Lines 1030 1054 +24
Branches 84 86 +2
=======================================
+ Hits 943 965 +22
- Misses 62 63 +1
- Partials 25 26 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #69
Fixes #78
This PR fixes an issue where subdataset provision did not work if
provisionwas invoked from an annex special remote-process.The reason for the error was that the special remote sets the environment variables
GIT_DIRandGIT_WORK_TREE, which lead to problems indatalad.get.