Little things #68
Merged
Little things #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In shell (bash, zsh), backticks are used for command subsititution. If datalad save gets a message "add `one-to-many` remake method", the shell will try the substitution, print (using zsh as example): "zsh: command not found: one-to-many", and the resulting commit message will be "add remake method". Hardly a big deal but let's replace them with single quotes. https://pubs.opengroup.org/onlinepubs/9799919799/utilities/V3_chap02.html#tag_19_06_03 https://zsh.sourceforge.io/Doc/Release/Expansion.html#Command-Substitution
These can appear when running code installed in editable mode (pip install -e); given that we already exclude things like .swp (vim swap file?), we can also exclude those (fwiw, datalad-next excludes both).
|
Great, thanks a lot @mslw |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes two little things - description in commits.