Skip to content

Commit

Permalink
fix: warn about incompatible make options
Browse files Browse the repository at this point in the history
This commit extends the `datalad make` docs
to describe the irrelevance of a
`--allow-trusted-execution` option, if
`--prospective-execution` is provided.
  • Loading branch information
christian-monch committed Dec 18, 2024
1 parent 0332201 commit bc2caf8
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion datalad_remake/commands/make_cmd.py
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,8 @@ class Make(ValidatedInterface):
doc='Skip commit signature verification before executing code. This '
'should only be used in a strictly controlled environment with '
'fully trusted datasets. Trusted dataset means: every commit '
'stems from a trusted entity. '
'stems from a trusted entity. This option has no effect when '
'combined with `--prospective-execution`. '
'DO NOT USE THIS OPTION, unless you are sure to understand the '
'consequences. One of which is that arbitrary parties can '
'execute arbitrary code under your account on your '
Expand Down Expand Up @@ -258,6 +259,11 @@ def __call__(
)
resolved_output = collect(worktree, ds, output_pattern)
else:
if allow_untrusted_execution:
lgr.warning(
'--allow-untrusted-execution has no effect if '
'--prospective-execution`is provided.'
)
resolved_output = set(output_pattern)

initialize_remotes(ds, resolved_output)
Expand Down

0 comments on commit bc2caf8

Please sign in to comment.