Enable full feature-set for datalad-annex:: on windows
#77
Conversation
mih
force-pushed
the
bf-26
branch
2 times, most recently
from
ded214e to
ad9db32
Compare
mih
changed the title
datalad-annex:: on windows
Codecov Report
@@ Coverage Diff @@
## main #77 +/- ##
==========================================
- Coverage 80.27% 80.07% -0.20%
==========================================
Files 27 27
Lines 2104 2108 +4
==========================================
- Hits 1689 1688 -1
- Misses 415 420 +5
Continue to review full report at Codecov.
|
This is a rather draconian workaround: Instead of dropping the repoannex keys, it wipes out the entire object tree of the local repoannex utility repo. This addresses https://git-annex.branchable.com/bugs/Fails_to_drop_key_on_windows___40__Access_denied__41__/?updated which is still happing with today's git-annex snapshot. This approach possible, because this utility repo is constructed on the fly from the URL specification, and only contains the two keys that need to be dropped. However, given the bluntness of the approach, it is limited to the platform on which the original issue is happening: windows. Closes #26
|
The coverage report is confusing. When starting this PR I specifically confirmed that the reenabled test actually fails on appveyor windows, and it nevertheless reports that same code it as "not covered". I'd say this is false and can be ignored here. |
There was a problem hiding this comment.
Given that this is a utility repo, I think the "blunt force" approach is fair (but please note that I have no experience with using git annex dropkey).
The doings of codecov are unfortunately opaque to me. But confusing indeed, if I'm reading the results correctly: despite complaints for "patch", the "project" coverage increased.
#26 is still valid with today's git-annex. This PR implements a rather draconian workaround: Instead of dropping the repoannex keys, it wipes out the entire object tree of the local
repoannexutility repo.This is possible, because this utility repo is constructed on the fly from the URL specification, and only contains the two keys that need to be dropped. However, given the bluntness of the approach, it is limited to the platform on which the original issue is happening: windows.