Free tree command from subdatasets dependency
#628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is practically a thin wrapper around `iter_gitworktree()` and the set of dependencies is therefore identical. Spreading the two across two packages is an invitation for circular dependencies. Moreover, there are no dedicated tests in `repo_utils`.
Same import pattern as others. Also hook into docs.
…ommand This is faster, and simpler.
|
Test failures are unrelated. QC complains about things not introduced here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation could now be made simpler, with fewer dependencies, using the new iterators. Here
iter_submodules().This use case also helped to identify suboptimal code organization. See individual commits.