Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not compare literal with is #527

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Do not compare literal with is #527

merged 1 commit into from
Oct 27, 2023

Conversation

mih
Copy link
Member

@mih mih commented Oct 27, 2023

SyntaxWarning: "is" with a literal. Did you mean "=="?

Closes #526

```
SyntaxWarning: "is" with a literal. Did you mean "=="?
```

Closes datalad#526
@mih mih added this to the 1.0.3 milestone Oct 27, 2023
@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d3e50bb) 92.46% compared to head (7c08113) 92.46%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #527   +/-   ##
=======================================
  Coverage   92.46%   92.46%           
=======================================
  Files         128      128           
  Lines        9647     9647           
  Branches     1045     1045           
=======================================
  Hits         8920     8920           
  Misses        703      703           
  Partials       24       24           
Files Coverage Δ
datalad_next/constraints/tests/test_compound.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mih mih merged commit dc0fcf6 into datalad:main Oct 27, 2023
@mih mih deleted the syntax-warn branch October 27, 2023 14:47
@mih mih added the semver-patch PR implies patch-level version increment (API stable) label Dec 6, 2023
@mih mih modified the milestones: 1.0.3, 1.1 Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-patch PR implies patch-level version increment (API stable)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Debian package installation embarrassing
1 participant