Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix and style unification #455

Merged
merged 3 commits into from
Sep 28, 2023
Merged

Bug fix and style unification #455

merged 3 commits into from
Sep 28, 2023

Conversation

christian-monch
Copy link
Contributor

This PR fixes a single f-string bug, unifies string-delimiters and homogenizes quote-usage in the doc string of the module

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (b153dae) 92.12% compared to head (603bf01) 92.09%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #455      +/-   ##
==========================================
- Coverage   92.12%   92.09%   -0.04%     
==========================================
  Files         122      122              
  Lines        9107     9107              
==========================================
- Hits         8390     8387       -3     
- Misses        717      720       +3     
Files Coverage Δ
datalad_next/annexremotes/uncurl.py 94.91% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mih mih added the semver-patch PR implies patch-level version increment (API stable) label Sep 28, 2023
Copy link
Member

@mih mih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx!

@mih mih merged commit c8f1efb into datalad:main Sep 28, 2023
mih added a commit that referenced this pull request Sep 28, 2023
@mih
Copy link
Member

mih commented Sep 28, 2023

Seems we did not test that, and still don't. Let's hope it lasts for a moment.

mih added a commit that referenced this pull request Sep 28, 2023
Add changelog item missing from #455
@mih mih added this to the 1.0.1 milestone Oct 16, 2023
@christian-monch christian-monch deleted the bf-uncurl branch July 16, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-patch PR implies patch-level version increment (API stable)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants